Skip to content

Commit 21642e7

Browse files
committed
src: clarify the parameter name in Permission::Apply
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <[email protected]>
1 parent 3d00354 commit 21642e7

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

src/permission/child_process_permission.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace permission {
99

1010
// Currently, ChildProcess manage a single state
1111
// Once denied, it's always denied
12-
void ChildProcessPermission::Apply(const std::string& deny,
12+
void ChildProcessPermission::Apply(const std::string& allow,
1313
PermissionScope scope) {
1414
deny_all_ = true;
1515
}

src/permission/child_process_permission.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace permission {
1212

1313
class ChildProcessPermission final : public PermissionBase {
1414
public:
15-
void Apply(const std::string& deny, PermissionScope scope) override;
15+
void Apply(const std::string& allow, PermissionScope scope) override;
1616
bool is_granted(PermissionScope perm,
1717
const std::string_view& param = "") override;
1818

src/permission/fs_permission.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace permission {
1616

1717
class FSPermission final : public PermissionBase {
1818
public:
19-
void Apply(const std::string& deny, PermissionScope scope) override;
19+
void Apply(const std::string& allow, PermissionScope scope) override;
2020
bool is_granted(PermissionScope perm, const std::string_view& param) override;
2121

2222
// For debugging purposes, use the gist function to print the whole tree

src/permission/permission.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class Permission {
4646
const std::string_view& res);
4747

4848
// CLI Call
49-
void Apply(const std::string& deny, PermissionScope scope);
49+
void Apply(const std::string& allow, PermissionScope scope);
5050
void EnablePermissions();
5151

5252
private:

src/permission/permission_base.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ enum class PermissionScope {
3636

3737
class PermissionBase {
3838
public:
39-
virtual void Apply(const std::string& deny, PermissionScope scope) = 0;
39+
virtual void Apply(const std::string& allow, PermissionScope scope) = 0;
4040
virtual bool is_granted(PermissionScope perm,
4141
const std::string_view& param = "") = 0;
4242
};

src/permission/worker_permission.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace permission {
99

1010
// Currently, PolicyDenyWorker manage a single state
1111
// Once denied, it's always denied
12-
void WorkerPermission::Apply(const std::string& deny, PermissionScope scope) {
12+
void WorkerPermission::Apply(const std::string& allow, PermissionScope scope) {
1313
deny_all_ = true;
1414
}
1515

src/permission/worker_permission.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace permission {
1212

1313
class WorkerPermission final : public PermissionBase {
1414
public:
15-
void Apply(const std::string& deny, PermissionScope scope) override;
15+
void Apply(const std::string& allow, PermissionScope scope) override;
1616
bool is_granted(PermissionScope perm,
1717
const std::string_view& param = "") override;
1818

0 commit comments

Comments
 (0)