test_runner: parse extra AssertionError YAML keys

Author: manekinekko

lib/internal/test_runner/tap_parser.js

@@ -14,9 +14,11 @@ const {
   ArrayPrototypeMap,
   ArrayPrototypePush,
   ArrayPrototypeIncludes,
+  Boolean,
   Number,
   RegExpPrototypeExec,
   RegExpPrototypeSymbolReplace,
+  String,
   StringPrototypeTrim,
   StringPrototypeSplit,
 } = primordials;
@@ -62,7 +64,7 @@ class TapParser extends Transform {
   #bufferedTestPoints = [];
   #flatAST = [];
   #subTestNestingLevel = 0;
-  #lastTestPointDuration = 0;
+  #lastTestPointDetails = {};
   #yamlBlockBuffer = [];
   #isYAMLBlock = false;
   #yamlCurrentIndentationLevel = 0;
@@ -209,7 +211,6 @@ class TapParser extends Transform {
 
     let astNode = this.#TAPDocument(chunk);
 
-
     // Mark the current chunk as processed
     // only when there is data to emit
     if (astNode) {
@@ -382,7 +383,10 @@ class TapParser extends Transform {
         lastNode?.kind === TokenKind.TAP_TEST_POINT &&
         lastNode?.nesting === value.nesting
       ) {
-        lastNode.node.time = this.#lastTestPointDuration;
+        lastNode.node.time = this.#lastTestPointDetails.duration;
+
+        // TODO(@manekinekko): figure out where to put the other diagnostic properties
+        // See https://github.com/nodejs/node/pull/44952
         lastNode.node.diagnostics ||= [];
 
         ArrayPrototypeForEach(value.node.diagnostics, (diagnostic) => {
@@ -395,8 +399,6 @@ class TapParser extends Transform {
         // No need to pass this node to the stream interface
         // because diagnostics are already added to the last test node
         return;
-
-
       }
 
       // Orphan YAML blocks? These are maybe general purpose YAML blocks
@@ -731,7 +733,6 @@ class TapParser extends Transform {
     }
 
     // If there is no comment content, then we ignore the current node
-
   }
 
   // ----------------YAMLBlock----------------
@@ -764,13 +765,13 @@ class TapParser extends Transform {
 
       this.#isYAMLBlock = true;
       this.#yamlCurrentIndentationLevel = this.#subTestNestingLevel;
+      this.#lastTestPointDetails = {};
 
       // Consume the YAML start marker
       this.#next(false); // skip "---"
 
       // No need to pass this token to the stream interface
       return;
-
     } else if (yamlBlockSymbol.kind === TokenKind.TAP_YAML_END) {
       this.#next(false); // skip "..."
 
@@ -812,11 +813,22 @@ class TapParser extends Transform {
     const yamlLiteral = this.#readNextLiterals();
     const { 0: key, 1: value } = StringPrototypeSplit(yamlLiteral, ':');
 
+    // Note that this.#lastTestPointDetails has been cleared when we encounter a YAML start marker
+
     switch (key) {
       case 'duration_ms':
-        this.#lastTestPointDuration = Number(value);
+        this.#lastTestPointDetails.duration = Number(value);
+        break;
+      // Below are diagnostic properties introduced in https://github.com/nodejs/node/pull/44952
+      case 'expected':
+        this.#lastTestPointDetails.expected = Boolean(value);
+        break;
+      case 'actual':
+        this.#lastTestPointDetails.actual = Boolean(value);
+        break;
+      case 'operator':
+        this.#lastTestPointDetails.operator = String(value);
         break;
-      // TODO(@manekinekko): should we handle other diagnostics data?
     }
 
     ArrayPrototypePush(this.#yamlBlockBuffer, yamlLiteral);
@@ -837,8 +849,10 @@ class TapParser extends Transform {
     let nextToken = this.#peek();
     while (
       nextToken &&
-      ArrayPrototypeIncludes([TokenKind.NEWLINE, TokenKind.EOF, TokenKind.EOL], nextToken.kind) ===
-        false
+      ArrayPrototypeIncludes(
+        [TokenKind.NEWLINE, TokenKind.EOF, TokenKind.EOL],
+        nextToken.kind
+      ) === false
     ) {
       let isEnabled = true;
       const pragmaKeySign = this.#next();