permission: fix data types in PrintTree

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

Author: tniessen

src/permission/fs_permission.cc

@@ -73,7 +73,7 @@ namespace node {
 
 namespace permission {
 
-void PrintTree(FSPermission::RadixTree::Node* node, int spaces = 0) {
+void PrintTree(const FSPermission::RadixTree::Node* node, size_t spaces = 0) {
   std::string whitespace(spaces, ' ');
 
   if (node == nullptr) {
@@ -90,8 +90,8 @@ void PrintTree(FSPermission::RadixTree::Node* node, int spaces = 0) {
                        whitespace,
                        node->prefix);
     if (node->children.size()) {
-      int child = 0;
-      for (const auto pair : node->children) {
+      size_t child = 0;
+      for (const auto& pair : node->children) {
         ++child;
         per_process::Debug(DebugCategory::PERMISSION_MODEL,
                            "%s Child(%s): %s\n",