fixup! fixup! build: add skip_apidoc_files and include QUIC

Author: RafaelGSS

doc/contributing/internal-api.md

@@ -39,3 +39,7 @@ Enables tracing of promises for debugging and performance analysis.
 #### `--verify-base-objects`
 
 Allows verification of base objects for debugging purposes.
+
+#### `--experimental-quic`
+
+Enable QUIC Protocol (under development)

src/node_options.cc

@@ -442,7 +442,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             kAllowedInEnvvar,
             true);
   AddOption("--experimental-quic",
-            "experimental QUIC API",
+            "" /* undocumented until its development */,
             &EnvironmentOptions::experimental_quic,
             kAllowedInEnvvar);
   AddOption("--experimental-webstorage",

test/parallel/test-cli-node-options-docs.js

@@ -25,8 +25,6 @@ const v8OptionsText = cliText.match(/<!-- v8-options start -->(.*)<!-- v8-option
 const manPage = path.join(rootDir, 'doc', 'node.1');
 const manPageText = fs.readFileSync(manPage, { encoding: 'utf8' });
 
-const ignoredDocs = ['--experimental-quic'];
-
 // Documented in /doc/api/deprecations.md
 const deprecated = [
   '--debug',
@@ -82,7 +80,7 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
   }
 
   // CLI options
-  if (!isV8Option && !hasTrueAsDefaultValue && !ignoredDocs.includes(envVar)) {
+  if (!isV8Option && !hasTrueAsDefaultValue) {
     if (new RegExp(`###.*\`${envVar}[[=\\s\\b\`]`).test(cliText) === false) {
       assert(false, `Should have option ${envVar} documented`);
     } else {
@@ -104,9 +102,7 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
 
   // NODE_OPTIONS
   if (isInNodeOption && !hasTrueAsDefaultValue &&
-    new RegExp(`\`${envVar}\``).test(nodeOptionsText) === false &&
-    !ignoredDocs.includes(envVar)
-  ) {
+    new RegExp(`\`${envVar}\``).test(nodeOptionsText) === false) {
     assert(false, `Should have option ${envVar} in NODE_OPTIONS documented`);
   }
 
@@ -126,10 +122,6 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
       manPagesOptions.delete(envVar.slice(1));
     }
   }
-
-  if (ignoredDocs.includes(envVar)) {
-    manPagesOptions.delete(envVar.slice(1));
-  }
 }
 
 {