fs: add encoding parameter to benchmarks

Author: anonrig

benchmark/fs/readfile-partitioned.js

@@ -17,12 +17,13 @@ const zlib = require('zlib');
 const assert = require('assert');
 
 const bench = common.createBenchmark(main, {
-  dur: [5],
+  duration: [5],
+  encoding: ['undefined', 'utf-8'],
   len: [1024, 16 * 1024 * 1024],
   concurrent: [1, 10]
 });
 
-function main({ len, dur, concurrent }) {
+function main({ len, duration, concurrent, encoding }) {
   try {
     fs.unlinkSync(filename);
   } catch {
@@ -47,10 +48,14 @@ function main({ len, dur, concurrent }) {
     } catch {
       // Continue regardless of error.
     }
-  }, dur * 1000);
+  }, duration * 1000);
 
   function read() {
-    fs.readFile(filename, afterRead);
+    if (encoding !== 'undefined') {
+      fs.readFile(filename, encoding, afterRead);
+    } else {
+      fs.readFile(filename, afterRead);
+    }
   }
 
   function afterRead(er, data) {

benchmark/fs/readfile-promises.js

@@ -15,11 +15,12 @@ const filename = path.resolve(tmpdir.path,
 
 const bench = common.createBenchmark(main, {
   duration: [5],
+  encoding: ['undefined', 'utf-8'],
   len: [1024, 16 * 1024 * 1024],
   concurrent: [1, 10]
 });
 
-function main({ len, duration, concurrent }) {
+function main({ len, duration, concurrent, encoding }) {
   try {
     fs.unlinkSync(filename);
   } catch {
@@ -44,7 +45,7 @@ function main({ len, duration, concurrent }) {
   }, duration * 1000);
 
   function read() {
-    fs.promises.readFile(filename)
+    fs.promises.readFile(filename, encoding === 'undefined' ? undefined : encoding)
       .then((res) => afterRead(undefined, res))
       .catch((err) => afterRead(err));
   }

benchmark/fs/readfile.js

@@ -15,11 +15,12 @@ const filename = path.resolve(tmpdir.path,
 
 const bench = common.createBenchmark(main, {
   duration: [5],
+  encoding: ['undefined', 'utf-8'],
   len: [1024, 16 * 1024 * 1024],
   concurrent: [1, 10]
 });
 
-function main({ len, duration, concurrent }) {
+function main({ len, duration, concurrent, encoding }) {
   try {
     fs.unlinkSync(filename);
   } catch {
@@ -44,7 +45,11 @@ function main({ len, duration, concurrent }) {
   }, duration * 1000);
 
   function read() {
-    fs.readFile(filename, afterRead);
+    if (encoding !== 'undefined') {
+      fs.readFile(filename, encoding, afterRead);
+    } else {
+      fs.readFile(filename, afterRead);
+    }
   }
 
   function afterRead(er, data) {