Skip to content

Commit 68f4651

Browse files
committed
fixup! src,node-api: fatal errors should not assume a current isolate may exist
1 parent e914bcf commit 68f4651

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

test/node-api/test_fatal/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@ const p = child_process.spawnSync(
1616
assert.ifError(p.error);
1717
assert.ok(p.stderr.toString().includes(
1818
'FATAL ERROR: test_fatal::Test fatal message'));
19+
assert.strictEqual(p.signal, 'SIGABRT');

test/node-api/test_fatal/test2.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@ const p = child_process.spawnSync(
1616
assert.ifError(p.error);
1717
assert.ok(p.stderr.toString().includes(
1818
'FATAL ERROR: test_fatal::Test fatal message'));
19+
assert.strictEqual(p.signal, 'SIGABRT');

test/node-api/test_fatal/test_threads.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ const p = child_process.spawnSync(
1717
assert.ifError(p.error);
1818
assert.ok(p.stderr.toString().includes(
1919
'FATAL ERROR: work_thread foobar'));
20+
assert.strictEqual(p.signal, 'SIGABRT');

0 commit comments

Comments
 (0)