remove env var

Author: guybedford

doc/api/cli.md

@@ -134,8 +134,7 @@ added: REPLACEME
 
 > Stability: 1 - Experimental
 
-Enables the `"development"` [conditional export][] in package resolution,
-while also setting `process.env.NODE_ENV` to `"development"`.
+Enables the `"development"` [conditional export][] in package resolution.
 
 ### `--disable-proto=mode`
 <!--YAML

doc/node.1

@@ -101,7 +101,7 @@ File name of the V8 CPU profile generated with
 .Fl -cpu-prof
 .
 .It Fl -dev
-Sets the development exports resolution and NODE_ENV environment variable.
+Enables the development mode conditional exports resolution.
 .
 .It Fl -disable-proto Ns = Ns Ar mode
 Disable the `Object.prototype.__proto__` property. If

lib/internal/bootstrap/pre_execution.js

@@ -174,9 +174,6 @@ function initializeReport() {
 }
 
 function setupDebugEnv() {
-  if (getOptionValue('--dev')) {
-    process.env.NODE_ENV = 'development';
-  }
   require('internal/util/debuglog').initializeDebugEnv(process.env.NODE_DEBUG);
   if (getOptionValue('--expose-internals')) {
     require('internal/bootstrap/loaders').NativeModule.exposeInternals();

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs

@@ -4,8 +4,10 @@ const dev = process.env.NODE_ENV === 'development';
 
 export async function resolve(specifier, context, defaultResolve) {
   ok(Array.isArray(context.conditions), 'loader receives conditions array');
-  deepStrictEqual([...context.conditions].sort(),
-      ['import', 'node', ...dev ? ['development'] : []]);
+  deepStrictEqual(
+    [...context.conditions].filter(c => c !== 'development').sort(),
+    ['import', 'node']
+  );
   return defaultResolve(specifier, {
     ...context,
     conditions: ['custom-condition', ...context.conditions],

test/fixtures/pkgexports-dev.mjs

@@ -1,17 +1,12 @@
 import { fileURLToPath } from 'url';
 import { createRequire } from 'module';
-import { strictEqual } from 'assert';
+import { strictEqual, AssertionError } from 'assert';
 
 const require = createRequire(fileURLToPath(import.meta.url));
-
-const expectValue =
-    process.env.NODE_ENV === 'development' ? 'development' : 'production';
-
-strictEqual(require('pkgexports-dev'), expectValue);
+const requireVal = require('pkgexports-dev');
 
 (async () => {
-  const { default: value } = await import('pkgexports-dev');
-  strictEqual(value, expectValue);
-
-  console.log(expectValue);
+  const { default: importVal } = await import('pkgexports-dev');
+  strictEqual(requireVal, importVal);
+  console.log(importVal);
 })();