crypto: remove getDefaultEncoding()

Refs: #47182
Refs: #47869
Refs: #47943
Refs: #47998
Refs: #49140
Refs: #49145
Refs: #49167
Refs: #49169
PR-URL: #49170
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Author: tniessen

lib/internal/crypto/util.js

@@ -75,11 +75,6 @@ const {
 const kHandle = Symbol('kHandle');
 const kKeyObject = Symbol('kKeyObject');
 
-// TODO(tniessen): remove all call sites and this function
-function getDefaultEncoding() {
-  return 'buffer';
-}
-
 // This is here because many functions accepted binary strings without
 // any explicit encoding in older versions of node, and we don't want
 // to break them unnecessarily.
@@ -555,7 +550,6 @@ module.exports = {
   getCiphers,
   getCurves,
   getDataViewOrTypedArrayBuffer,
-  getDefaultEncoding,
   getHashes,
   kHandle,
   kKeyObject,

lib/internal/streams/lazy_transform.js

@@ -11,10 +11,6 @@ const {
 
 const stream = require('stream');
 
-const {
-  getDefaultEncoding,
-} = require('internal/crypto/util');
-
 module.exports = LazyTransform;
 
 function LazyTransform(options) {
@@ -29,7 +25,7 @@ function makeGetter(name) {
     this._writableState.decodeStrings = false;
 
     if (!this._options || !this._options.defaultEncoding) {
-      this._writableState.defaultEncoding = getDefaultEncoding();
+      this._writableState.defaultEncoding = 'buffer';  // TODO(tniessen): remove
     }
 
     return this[name];