test: fix order of values in test assertions

Have actual first, expected second.

PR-URL: #23450
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Author: jehaines

test/parallel/test-http-server.js

@@ -37,23 +37,23 @@ const server = http.createServer(function(req, res) {
   req.id = request_number++;
 
   if (req.id === 0) {
-    assert.strictEqual('GET', req.method);
-    assert.strictEqual('/hello', url.parse(req.url).pathname);
-    assert.strictEqual('world', qs.parse(url.parse(req.url).query).hello);
-    assert.strictEqual('b==ar', qs.parse(url.parse(req.url).query).foo);
+    assert.strictEqual(req.method, 'GET');
+    assert.strictEqual(url.parse(req.url).pathname, '/hello');
+    assert.strictEqual(qs.parse(url.parse(req.url).query).hello, 'world');
+    assert.strictEqual(qs.parse(url.parse(req.url).query).foo, 'b==ar');
   }
 
   if (req.id === 1) {
-    assert.strictEqual('POST', req.method);
-    assert.strictEqual('/quit', url.parse(req.url).pathname);
+    assert.strictEqual(req.method, 'POST');
+    assert.strictEqual(url.parse(req.url).pathname, '/quit');
   }
 
   if (req.id === 2) {
-    assert.strictEqual('foo', req.headers['x-x']);
+    assert.strictEqual(req.headers['x-x'], 'foo');
   }
 
   if (req.id === 3) {
-    assert.strictEqual('bar', req.headers['x-x']);
+    assert.strictEqual(req.headers['x-x'], 'bar');
     this.close();
   }
 
@@ -112,14 +112,14 @@ server.on('listening', function() {
 });
 
 process.on('exit', function() {
-  assert.strictEqual(4, request_number);
-  assert.strictEqual(4, requests_sent);
+  assert.strictEqual(request_number, 4);
+  assert.strictEqual(requests_sent, 4);
 
   const hello = new RegExp('/hello');
   assert.ok(hello.test(server_response));
 
   const quit = new RegExp('/quit');
   assert.ok(quit.test(server_response));
 
-  assert.strictEqual(true, client_got_eof);
+  assert.strictEqual(client_got_eof, true);
 });