Commit 828640a
committed
src: remove fast API for InternalModuleStat
There are several motivation for removing this:
1. The implementation does not align with InternalModuleStat,
most noticably it does not namespace the path or convert
it to UTF-16 before using it with std::filesystem::path
on Windows which could crash on non-English locale.
2. It needs the Environment - if not for decoding the string,
at least for env->exec_path() to resolve the path for
namespacing - and therefore needs a handle to the Context
which requires a handle scope which actually makes the
fast API version slower than the normal binding.
For simplicity this just removes the fast API to fix the bug and
improve the performance.1 parent 5a23443 commit 828640a
1 file changed
+1
-33
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1073 | 1073 | | |
1074 | 1074 | | |
1075 | 1075 | | |
1076 | | - | |
1077 | | - | |
1078 | | - | |
1079 | | - | |
1080 | | - | |
1081 | | - | |
1082 | | - | |
1083 | | - | |
1084 | | - | |
1085 | | - | |
1086 | | - | |
1087 | | - | |
1088 | | - | |
1089 | | - | |
1090 | | - | |
1091 | | - | |
1092 | | - | |
1093 | | - | |
1094 | | - | |
1095 | | - | |
1096 | | - | |
1097 | | - | |
1098 | | - | |
1099 | | - | |
1100 | | - | |
1101 | | - | |
1102 | 1076 | | |
1103 | 1077 | | |
1104 | 1078 | | |
| |||
3722 | 3696 | | |
3723 | 3697 | | |
3724 | 3698 | | |
3725 | | - | |
3726 | | - | |
3727 | | - | |
3728 | | - | |
3729 | | - | |
| 3699 | + | |
3730 | 3700 | | |
3731 | 3701 | | |
3732 | 3702 | | |
| |||
3851 | 3821 | | |
3852 | 3822 | | |
3853 | 3823 | | |
3854 | | - | |
3855 | | - | |
3856 | 3824 | | |
3857 | 3825 | | |
3858 | 3826 | | |
| |||
0 commit comments