lib: add String primordials

Author: Sebastien-Ahkrin

lib/.eslintrc.yaml

@@ -41,6 +41,8 @@ rules:
       message: "Use `const { RegExp } = primordials;` instead of the global."
     - name: Set
       message: "Use `const { Set } = primordials;` instead of the global."
+    - name: String
+      message: "Use `const { String } = primordials;` instead of the global."
     - name: Symbol
       message: "Use `const { Symbol } = primordials;` instead of the global."
     - name: Uint16Array

lib/_http_client.js

@@ -29,6 +29,7 @@ const {
   ObjectAssign,
   ObjectKeys,
   ObjectSetPrototypeOf,
+  String,
   Symbol
 } = primordials;
 

lib/assert.js

@@ -29,6 +29,7 @@ const {
   Map,
   NumberIsNaN,
   RegExpPrototypeTest,
+  String,
 } = primordials;
 
 const { Buffer } = require('buffer');

lib/events.js

@@ -36,6 +36,7 @@ const {
   PromiseResolve,
   ReflectApply,
   ReflectOwnKeys,
+  String,
   Symbol,
   SymbolFor,
   SymbolAsyncIterator

lib/internal/assert/assertion_error.js

@@ -7,6 +7,7 @@ const {
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
   ObjectKeys,
+  String,
 } = primordials;
 
 const { inspect } = require('internal/util/inspect');

lib/internal/bootstrap/loaders.js

@@ -52,6 +52,7 @@ const {
   ObjectPrototypeHasOwnProperty,
   ReflectGet,
   SafeSet,
+  String,
 } = primordials;
 
 // Set up process.moduleLoadList.

lib/internal/errors.js

@@ -19,8 +19,12 @@ const {
   NumberIsInteger,
   ObjectDefineProperty,
   ObjectKeys,
+<<<<<<< HEAD
   StringPrototypeSlice,
   StringPrototypeStartsWith,
+=======
+  String,
+>>>>>>> lib: add String primordials
   Symbol,
   SymbolFor,
   WeakMap,

lib/internal/http2/util.js

@@ -8,6 +8,7 @@ const {
   ObjectCreate,
   ObjectKeys,
   Set,
+  String,
   Symbol,
 } = primordials;
 

lib/internal/modules/cjs/loader.js

@@ -39,7 +39,10 @@ const {
   ReflectSet,
   RegExpPrototypeTest,
   SafeMap,
+<<<<<<< HEAD
   SafeWeakMap,
+=======
+>>>>>>> lib: add String primordials
   String,
   StringPrototypeIndexOf,
   StringPrototypeLastIndexOf,

lib/internal/process/warning.js

@@ -3,6 +3,7 @@
 const {
   ArrayIsArray,
   Error,
+  String,
 } = primordials;
 
 const assert = require('internal/assert');