fixup! assert: refactor to avoid unsafe array iteration

aduh95 · aduh95 · commit bbde06dfe3ac · 2021-02-13T17:42:12.000+01:00
diff --git a/lib/internal/assert/assertion_error.js b/lib/internal/assert/assertion_error.js
@@ -314,13 +314,14 @@ function createErrDiff(actual, expected, operator) {
 }
 
 function addEllipsis(string) {
-  const lines = StringPrototypeSplit(string, '\n');
+  const lines = StringPrototypeSplit(string, '\n', 11);
   if (lines.length > 10) {
     lines.length = 10;
     return `${ArrayPrototypeJoin(lines, '\n')}\n...`;
   } else if (string.length > 512) {
     return `${StringPrototypeSlice(string, 512)}...`;
   }
+  return string;
 }
 
 class AssertionError extends Error {

Original file line number	Diff line number	Diff line change
`@@ -314,13 +314,14 @@ function createErrDiff(actual, expected, operator) {`
`314`	`314`	`}`
`315`	`315`
`316`	`316`	`function addEllipsis(string) {`
`317`		`- const lines = StringPrototypeSplit(string, '\n');`
	`317`	`+ const lines = StringPrototypeSplit(string, '\n', 11);`
`318`	`318`	`if (lines.length > 10) {`
`319`	`319`	`lines.length = 10;`
`320`	`320`	return `${ArrayPrototypeJoin(lines, '\n')}\n...`;
`321`	`321`	`} else if (string.length > 512) {`
`322`	`322`	return `${StringPrototypeSlice(string, 512)}...`;
`323`	`323`	`}`
	`324`	`+ return string;`
`324`	`325`	`}`
`325`	`326`
`326`	`327`	`class AssertionError extends Error {`