@@ -496,12 +496,11 @@ There is a minimum waiting time which we try to respect for non-trivial
496496changes, so that people who may have important input in such a distributed
497497project are able to respond.
498498
499- For non-trivial changes, Pull Requests must be left open for * at least* 48
500- hours during the week, and 72 hours on a weekend. In most cases, when the
501- PR is relatively small and focused on a narrow set of changes, these periods
502- provide more than enough time to adequately review. Sometimes changes take far
503- longer to review, or need more specialized review from subject matter experts.
504- When in doubt, do not rush.
499+ For non-trivial changes, Pull Requests must be left open for at least 48 hours.
500+ In most cases, when the PR is relatively small and focused on a narrow set of
501+ changes, that will provide more than enough time to adequately review. Sometimes
502+ changes take far longer to review, or need more specialized review from subject
503+ matter experts. When in doubt, do not rush.
505504
506505Trivial changes, typically limited to small formatting changes or fixes to
507506documentation, may be landed within the minimum 48 hour window.
@@ -643,12 +642,11 @@ If not, you can ask a Collaborator to start a CI run.
643642
644643### Waiting Until the Pull Request Gets Landed
645644
646- A Pull Request needs to stay open for at least 48 hours (72 hours on a
647- weekend) from when it is submitted, even after it gets approved and
648- passes the CI. This is to make sure that everyone has a chance to
649- weigh in. If the changes are trivial, collaborators may decide it
650- doesn't need to wait. A Pull Request may well take longer to be
651- merged in. All these precautions are important because Node.js is
645+ A Pull Request needs to stay open for at least 48 hours from when it is
646+ submitted, even after it gets approved and passes the CI. This is to make sure
647+ that everyone has a chance to weigh in. If the changes are trivial,
648+ collaborators may decide it doesn't need to wait. A Pull Request may well take
649+ longer to be merged in. All these precautions are important because Node.js is
652650widely used, so don't be discouraged!
653651
654652### Check Out the Collaborator Guide
0 commit comments