Skip to content

Commit faa64c3

Browse files
committed
deps: remove problematic comment from v8-internal
GCC emits warnings because of the trailing backslashes. PR-URL: #58070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent c0b8c80 commit faa64c3

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.2',
41+
'v8_embedder_string': '-node.3',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/include/v8-internal.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -434,19 +434,6 @@ constexpr size_t kMaxCppHeapPointers = 0;
434434
// which all subtypes of a given supertype use contiguous tags. This struct can
435435
// then be used to represent such a type range.
436436
//
437-
// As an example, consider the following type hierarchy:
438-
//
439-
// A F
440-
// / \
441-
// B E
442-
// / \
443-
// C D
444-
//
445-
// A potential type id assignment for range-based type checks is
446-
// {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A
447-
// would check for the range [A, E], while the check for B would check range
448-
// [B, D], and for F it would simply check [F, F].
449-
//
450437
// In addition, there is an option for performance tweaks: if the size of the
451438
// type range corresponding to a supertype is a power of two and starts at a
452439
// power of two (e.g. [0x100, 0x13f]), then the compiler can often optimize

0 commit comments

Comments
 (0)