From bf3d990d82b8d3c0bf121766e206ec26825dbc42 Mon Sep 17 00:00:00 2001 From: Bradley Farias Date: Thu, 12 Oct 2017 08:33:39 -0500 Subject: [PATCH 1/3] doc: ensure collaborators validate commits This should be done every time a collaborator pushes a commit. --- COLLABORATOR_GUIDE.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index f60eba21aaf2b3..41e4ddd9abfcf2 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -517,6 +517,12 @@ Run tests (`make -j4 test` or `vcbuild test`). Even though there was a successful continuous integration run, other changes may have landed on master since then, so running the tests one last time locally is a good practice. +Validate that the commit message is properly formatted using [core-validate-commit](https://github.com/evanlucas/core-validate-commit). + +```text +$ core-validate-commit +``` + Time to push it: ```text From 94ca2e49804c316b90a8b097fc5ad7e10815be3c Mon Sep 17 00:00:00 2001 From: Bradley Farias Date: Thu, 12 Oct 2017 09:38:35 -0500 Subject: [PATCH 2/3] nit 80 col --- COLLABORATOR_GUIDE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 41e4ddd9abfcf2..86e325f3fda058 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -517,7 +517,8 @@ Run tests (`make -j4 test` or `vcbuild test`). Even though there was a successful continuous integration run, other changes may have landed on master since then, so running the tests one last time locally is a good practice. -Validate that the commit message is properly formatted using [core-validate-commit](https://github.com/evanlucas/core-validate-commit). +Validate that the commit message is properly formatted using +[core-validate-commit](https://github.com/evanlucas/core-validate-commit). ```text $ core-validate-commit From 2da60dc14813f20b9e57f620b8bdbb30774abd32 Mon Sep 17 00:00:00 2001 From: Bradley Farias Date: Thu, 12 Oct 2017 12:28:10 -0500 Subject: [PATCH 3/3] xargs commits --- COLLABORATOR_GUIDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 86e325f3fda058..9bf569687ccec3 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -521,7 +521,7 @@ Validate that the commit message is properly formatted using [core-validate-commit](https://github.com/evanlucas/core-validate-commit). ```text -$ core-validate-commit +$ git rev-list upstream/master...HEAD | xargs core-validate-commit ``` Time to push it: