(v6.x backport) crypto: warn on invalid authentication tag length #18347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using authentication tags of invalid length does not conform to NIST standards. PR-URL: nodejs#17566 Refs: nodejs#17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#17566 Refs: nodejs#17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
added
c++
4 tasks
Contributor
Contributor
|
So I'm thinking that this maybe should have been semver-minor on v9.x... as such we maybe shouldn't land this in v6.x or v8.x for now. It might make sense to revisit in a later semver-minor, but we had already disqualified minors from v6.4.0 @gibfahn should we back this out of v8.x? |
Member
Author
|
@MylesBorins I don't have a strong opinion here, but this and #18376 are probably the only things we can do to prevent users from exposing themselves to inauthentic messages, so I would suggest to backport as soon as possible. cc @bnoordhuis |
Contributor
|
landed in 076ca9f...7ed3e85 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 10, 2018
Using authentication tags of invalid length does not conform to NIST standards. Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 10, 2018
Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Using authentication tags of invalid length does not conform to NIST standards. Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Using authentication tags of invalid length does not conform to NIST standards. Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Using authentication tags of invalid length does not conform to NIST standards. Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Backport-PR-URL: #18347 PR-URL: #17566 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #17566 to v6.x.