From b618931c43b13ab8521d0a4d59649080cabd240b Mon Sep 17 00:00:00 2001 From: Bartosz Sosnowski Date: Tue, 15 May 2018 20:45:17 +0200 Subject: [PATCH 1/2] doc: add note about autocrlf required for tests Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully. Ref: https://github.com/nodejs/node/issues/18967 --- test/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/README.md b/test/README.md index bc2464bcfaecdf..f2d73d7d494e73 100644 --- a/test/README.md +++ b/test/README.md @@ -8,6 +8,9 @@ directory, see [the guide on writing tests](../doc/guides/writing-tests.md). On how to run tests in this directory, see [the contributing guide](../doc/guides/contributing/pull-requests.md#step-6-test). +For the test to successfully run on Windows, Node.js has to be checked out from +GitHub with the `autocrlf` git config flag set to true. + ## Test Directories |Directory |Runs on CI |Purpose | From 91c05a53725a789e5d04df89f56d8a0671c3b458 Mon Sep 17 00:00:00 2001 From: Bartosz Sosnowski Date: Wed, 16 May 2018 14:26:47 +0200 Subject: [PATCH 2/2] fixup: test -> tests --- test/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/README.md b/test/README.md index f2d73d7d494e73..302db9d0bb8ad7 100644 --- a/test/README.md +++ b/test/README.md @@ -8,7 +8,7 @@ directory, see [the guide on writing tests](../doc/guides/writing-tests.md). On how to run tests in this directory, see [the contributing guide](../doc/guides/contributing/pull-requests.md#step-6-test). -For the test to successfully run on Windows, Node.js has to be checked out from +For the tests to successfully run on Windows, Node.js has to be checked out from GitHub with the `autocrlf` git config flag set to true. ## Test Directories