doc: add GitHub email set up link to COLLABORATOR_GUIDE #22525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Aug 25, 2018
trivikr
approved these changes
Aug 25, 2018
lundibundi
added
the
author ready
cjihrig
reviewed
Aug 25, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Instead of saying "this and this guides" how about linking from the words "username" and "email" and dropping the part about guides.
Member
Author
|
@cjihrig seems good to me. |
lundibundi
removed
the
author ready
refack
approved these changes
Aug 25, 2018
lundibundi
added
the
author ready
cjihrig
approved these changes
Aug 25, 2018
Member
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
gdams
approved these changes
Aug 26, 2018
vsemozhetbyt
approved these changes
Aug 26, 2018
Member
|
landed as fast-track in: 317b894 |
gdams
pushed a commit
that referenced
this pull request
Aug 26, 2018
PR-URL: #22525 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 27, 2018
PR-URL: #22525 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22525 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22525 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) passes