From 2401b0d5a250febf5e648f712c962b0b6c665e20 Mon Sep 17 00:00:00 2001 From: cclauss Date: Mon, 28 Jan 2019 15:15:31 +0100 Subject: [PATCH 1/5] build: update prerequisites on progress towards Python 3 As recommended at https://github.com/nodejs/node/pull/25759#issuecomment-458139766 * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus --- BUILDING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index fbd435172aa3d8..d48dd95ba8c549 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -165,6 +165,9 @@ explains how to install all prerequisites. * `gcc` and `g++` 4.9.4 or newer, or * `clang` and `clang++` 3.4.2 or newer (macOS: latest Xcode Command Line Tools) * Python 2.6 or 2.7 + * Python 2.6 reached its end of life in 2013 so its use is discouraged. + * Python 2.7 reaches its end of life at the end of 2019 so a transition to Python 3 is underway + * Python 3.5, 3.6, nad 3.7 are intended to be supported in the near future * GNU Make 3.81 or newer On macOS, install the `Xcode Command Line Tools` by running @@ -193,7 +196,7 @@ may reduce build time. For more information, see the [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html). Note that the above requires that `python` resolve to Python 2.6 or 2.7 -and not a newer version. +and not a newer version. See the above notes on __Prerequisites__. After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid popups asking to accept incoming network connections when running tests. From 35ec6a237572b49d283a781c7311e7872961d231 Mon Sep 17 00:00:00 2001 From: cclauss Date: Mon, 28 Jan 2019 15:58:28 +0100 Subject: [PATCH 2/5] Fix typo: 'nad' --> 'and' --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index d48dd95ba8c549..61861d8363dee7 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -167,7 +167,7 @@ explains how to install all prerequisites. * Python 2.6 or 2.7 * Python 2.6 reached its end of life in 2013 so its use is discouraged. * Python 2.7 reaches its end of life at the end of 2019 so a transition to Python 3 is underway - * Python 3.5, 3.6, nad 3.7 are intended to be supported in the near future + * Python 3.5, 3.6, and 3.7 are intended to be supported in the near future * GNU Make 3.81 or newer On macOS, install the `Xcode Command Line Tools` by running From 6b3f94e2f8e9bca5cb5b4d3b5def93dce21f57c0 Mon Sep 17 00:00:00 2001 From: cclauss Date: Mon, 28 Jan 2019 16:22:01 +0100 Subject: [PATCH 3/5] Fix remark-lint warnings --- BUILDING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 61861d8363dee7..dbb0200b263717 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -166,8 +166,8 @@ explains how to install all prerequisites. * `clang` and `clang++` 3.4.2 or newer (macOS: latest Xcode Command Line Tools) * Python 2.6 or 2.7 * Python 2.6 reached its end of life in 2013 so its use is discouraged. - * Python 2.7 reaches its end of life at the end of 2019 so a transition to Python 3 is underway - * Python 3.5, 3.6, and 3.7 are intended to be supported in the near future + * Python 2.7 end of life is in 2019 so a transition to Python 3 is underway. + * Python 3.5, 3.6, and 3.7 are intended to be supported in the near future. * GNU Make 3.81 or newer On macOS, install the `Xcode Command Line Tools` by running @@ -196,7 +196,7 @@ may reduce build time. For more information, see the [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html). Note that the above requires that `python` resolve to Python 2.6 or 2.7 -and not a newer version. See the above notes on __Prerequisites__. +and not a newer version. See the above notes on **Prerequisites**. After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid popups asking to accept incoming network connections when running tests. From 7f9f32cd6684b5ee5b5d82aec29a7c897fdd7a9e Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 28 Jan 2019 22:17:21 +0100 Subject: [PATCH 4/5] Link up to Prerequisites Co-Authored-By: cclauss --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index dbb0200b263717..e6011c21c17b7c 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -196,7 +196,7 @@ may reduce build time. For more information, see the [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html). Note that the above requires that `python` resolve to Python 2.6 or 2.7 -and not a newer version. See the above notes on **Prerequisites**. +and not a newer version. See [Prerequisites](#prerequisites). After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid popups asking to accept incoming network connections when running tests. From 8ccb148ec82aec8b14f7cd7810c7ada26cd174be Mon Sep 17 00:00:00 2001 From: cclauss Date: Tue, 29 Jan 2019 16:27:56 +0100 Subject: [PATCH 5/5] Drop all mention of Python 2.6 --- BUILDING.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index e6011c21c17b7c..7f5605e9f4596f 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -164,10 +164,9 @@ explains how to install all prerequisites. * `gcc` and `g++` 4.9.4 or newer, or * `clang` and `clang++` 3.4.2 or newer (macOS: latest Xcode Command Line Tools) -* Python 2.6 or 2.7 - * Python 2.6 reached its end of life in 2013 so its use is discouraged. +* Python 2.7 * Python 2.7 end of life is in 2019 so a transition to Python 3 is underway. - * Python 3.5, 3.6, and 3.7 are intended to be supported in the near future. + * Python 3.5, 3.6, and 3.7 are experimental. * GNU Make 3.81 or newer On macOS, install the `Xcode Command Line Tools` by running @@ -195,8 +194,8 @@ The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which may reduce build time. For more information, see the [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html). -Note that the above requires that `python` resolve to Python 2.6 or 2.7 -and not a newer version. See [Prerequisites](#prerequisites). +Note that the above requires that `python` resolve to Python 2.7 and not a newer +version. See [Prerequisites](#prerequisites). After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid popups asking to accept incoming network connections when running tests. @@ -403,7 +402,7 @@ $ backtrace Prerequisites: -* [Python 2.6 or 2.7](https://www.python.org/downloads/) +* [Python 2.7](https://www.python.org/downloads/) * The "Desktop development with C++" workload from [Visual Studio 2017](https://www.visualstudio.com/downloads/) or the "Visual C++ build tools" workload from the