diff --git a/benchmark/_benchmark_progress.js b/benchmark/_benchmark_progress.js index 935b1f24d49673..1b7ac738f6de0d 100644 --- a/benchmark/_benchmark_progress.js +++ b/benchmark/_benchmark_progress.js @@ -35,7 +35,6 @@ class BenchmarkProgress { // Number of times each file will be run (roughly). this.runsPerFile = queue.length / benchmarks.length; this.currentFile = ''; // Filename of current benchmark. - this.currentFileConfig; // Configurations for current file // Number of configurations already run for the current file. this.completedConfig = 0; // Total number of configurations for the current file diff --git a/benchmark/es/foreach-bench.js b/benchmark/es/foreach-bench.js index 25ea97b44d5695..f424ca7a2552b2 100644 --- a/benchmark/es/foreach-bench.js +++ b/benchmark/es/foreach-bench.js @@ -12,19 +12,18 @@ function useFor(n, items, count) { bench.start(); for (var i = 0; i < n; i++) { for (var j = 0; j < count; j++) { - /* eslint-disable no-unused-vars */ + // eslint-disable-next-line no-unused-vars const item = items[j]; - /* esline-enable no-unused-vars */ } } bench.end(n); } function useForOf(n, items) { - var item; bench.start(); for (var i = 0; i < n; i++) { - for (item of items) {} + // eslint-disable-next-line no-unused-vars + for (const item of items) {} } bench.end(n); } @@ -33,9 +32,8 @@ function useForIn(n, items) { bench.start(); for (var i = 0; i < n; i++) { for (var j in items) { - /* eslint-disable no-unused-vars */ + // eslint-disable-next-line no-unused-vars const item = items[j]; - /* esline-enable no-unused-vars */ } } bench.end(n); diff --git a/doc/guides/writing-and-running-benchmarks.md b/doc/guides/writing-and-running-benchmarks.md index 5838449612b541..e6ccf163d3e27a 100644 --- a/doc/guides/writing-and-running-benchmarks.md +++ b/doc/guides/writing-and-running-benchmarks.md @@ -470,6 +470,6 @@ Supported options keys are: [autocannon]: https://github.com/mcollina/autocannon [wrk]: https://github.com/wg/wrk [t-test]: https://en.wikipedia.org/wiki/Student%27s_t-test#Equal_or_unequal_sample_sizes.2C_unequal_variances -[git-for-windows]: http://git-scm.com/download/win -[nghttp2.org]: http://nghttp2.org +[git-for-windows]: https://git-scm.com/download/win +[nghttp2.org]: https://nghttp2.org [benchmark-ci]: https://github.com/nodejs/benchmarking/blob/master/docs/core_benchmarks.md