From d4e47614d1f73cef01027043c577e16b790ee26e Mon Sep 17 00:00:00 2001 From: Moshe Atlow Date: Sat, 30 Jul 2022 23:36:42 +0300 Subject: [PATCH 1/2] test_runner: empty pending tests queue post running --- lib/internal/test_runner/test.js | 1 + test/message/test_runner_unresolved_promise.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js index 3172d1ec2b40a5..9ea04dfceba527 100644 --- a/lib/internal/test_runner/test.js +++ b/lib/internal/test_runner/test.js @@ -523,6 +523,7 @@ class Test extends AsyncResource { // The test has run, so recursively cancel any outstanding subtests and // mark this test as failed if any subtests failed. + this.pendingSubtests = []; for (let i = 0; i < this.subtests.length; i++) { const subtest = this.subtests[i]; diff --git a/test/message/test_runner_unresolved_promise.js b/test/message/test_runner_unresolved_promise.js index 00d231be34b6df..a36652669fc0a9 100644 --- a/test/message/test_runner_unresolved_promise.js +++ b/test/message/test_runner_unresolved_promise.js @@ -5,4 +5,4 @@ const test = require('node:test'); test('pass'); test('never resolving promise', () => new Promise(() => {})); -test('fail'); +test('fail', () => console.log('this should not appear')); From dcab352ad0c83ce6eea24eb8dfe4d576fc67d6e8 Mon Sep 17 00:00:00 2001 From: Moshe Atlow Date: Sun, 31 Jul 2022 00:26:10 +0300 Subject: [PATCH 2/2] I want this checked as well --- test/message/test_runner_unresolved_promise.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/message/test_runner_unresolved_promise.out b/test/message/test_runner_unresolved_promise.out index d4e868cc9ef3c3..2bb543cd4554fe 100644 --- a/test/message/test_runner_unresolved_promise.out +++ b/test/message/test_runner_unresolved_promise.out @@ -17,7 +17,7 @@ not ok 2 - never resolving promise # Subtest: fail not ok 3 - fail --- - duration_ms: * + duration_ms: 0 failureType: 'cancelledByParent' error: 'test did not finish before its parent and was cancelled' code: 'ERR_TEST_FAILURE'