From 26f10b0ece38990f0bea3ca56012514a68e23d59 Mon Sep 17 00:00:00 2001 From: Jiawen Geng Date: Fri, 13 Jan 2023 01:41:46 +0000 Subject: [PATCH 1/2] build: add extra semi check --- node.gyp | 1 + node.gypi | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/node.gyp b/node.gyp index f1844720762529..f5da2fa3599ed1 100644 --- a/node.gyp +++ b/node.gyp @@ -96,6 +96,7 @@ '-W', '-Wno-unused-parameter', '-Werror=undefined-inline', + '-Werror=extra-semi', ], }, diff --git a/node.gypi b/node.gypi index ecd2ea6ea87deb..e8dd7fe2be3100 100644 --- a/node.gypi +++ b/node.gypi @@ -27,7 +27,7 @@ 'conditions': [ [ 'clang==1', { - 'cflags': [ '-Werror=undefined-inline', ] + 'cflags': [ '-Werror=undefined-inline', '-Werror=extra-semi'] }], [ '"<(_type)"=="executable"', { 'msvs_settings': { From 5eb2c67ef5ab3595ee11050a693df4ebfd11daf3 Mon Sep 17 00:00:00 2001 From: Jiawen Geng Date: Mon, 16 Jan 2023 06:53:51 +0000 Subject: [PATCH 2/2] deps: cherrypick simdutf patch --- deps/simdutf/simdutf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/simdutf/simdutf.h b/deps/simdutf/simdutf.h index 3514f117dd2360..f3f63e78d94d7b 100644 --- a/deps/simdutf/simdutf.h +++ b/deps/simdutf/simdutf.h @@ -1599,7 +1599,7 @@ class implementation { * * @return a mask of all required `internal::instruction_set::` values */ - virtual uint32_t required_instruction_sets() const { return _required_instruction_sets; }; + virtual uint32_t required_instruction_sets() const { return _required_instruction_sets; } /**