From 7331c24fb7d772a00f9c6896d5082a2b07b4ee9f Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 9 Mar 2023 14:47:05 +0100 Subject: [PATCH 1/2] test: move `test-tls-autoselectfamily-servername` to `test/internet` And switch from `google.com` to `nodejs.org`. --- .../test-tls-autoselectfamily-servername.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) rename test/{parallel => internet}/test-tls-autoselectfamily-servername.js (88%) diff --git a/test/parallel/test-tls-autoselectfamily-servername.js b/test/internet/test-tls-autoselectfamily-servername.js similarity index 88% rename from test/parallel/test-tls-autoselectfamily-servername.js rename to test/internet/test-tls-autoselectfamily-servername.js index f2b0f7b3499b85..310bea9a1883d3 100644 --- a/test/parallel/test-tls-autoselectfamily-servername.js +++ b/test/internet/test-tls-autoselectfamily-servername.js @@ -15,9 +15,9 @@ setDefaultAutoSelectFamilyAttemptTimeout(common.platformTimeout(common.isWindows // Test that TLS connecting works without autoSelectFamily { const socket = connect({ - host: 'google.com', + host: 'nodejs.org', port: 443, - servername: 'google.com', + servername: 'nodejs.org', autoSelectFamily: false, }); @@ -27,9 +27,9 @@ setDefaultAutoSelectFamilyAttemptTimeout(common.platformTimeout(common.isWindows // Test that TLS connecting works with autoSelectFamily { const socket = connect({ - host: 'google.com', + host: 'nodejs.org', port: 443, - servername: 'google.com', + servername: 'nodejs.org', autoSelectFamily: true, }); From a130ca1234b293a017aac4ac5de580a7e5548d7b Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 9 Mar 2023 22:00:41 +0100 Subject: [PATCH 2/2] fixup! test: move `test-tls-autoselectfamily-servername` to `test/internet` --- test/internet/test-tls-autoselectfamily-servername.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/internet/test-tls-autoselectfamily-servername.js b/test/internet/test-tls-autoselectfamily-servername.js index 310bea9a1883d3..ae53875b677821 100644 --- a/test/internet/test-tls-autoselectfamily-servername.js +++ b/test/internet/test-tls-autoselectfamily-servername.js @@ -1,6 +1,7 @@ 'use strict'; const common = require('../common'); +const { addresses: { INET_HOST } } = require('../common/internet'); if (!common.hasCrypto) { common.skip('missing crypto'); @@ -15,9 +16,9 @@ setDefaultAutoSelectFamilyAttemptTimeout(common.platformTimeout(common.isWindows // Test that TLS connecting works without autoSelectFamily { const socket = connect({ - host: 'nodejs.org', + host: INET_HOST, port: 443, - servername: 'nodejs.org', + servername: INET_HOST, autoSelectFamily: false, }); @@ -27,9 +28,9 @@ setDefaultAutoSelectFamilyAttemptTimeout(common.platformTimeout(common.isWindows // Test that TLS connecting works with autoSelectFamily { const socket = connect({ - host: 'nodejs.org', + host: INET_HOST, port: 443, - servername: 'nodejs.org', + servername: INET_HOST, autoSelectFamily: true, });