Skip to content

deps: update nghttp2 to 1.57.0 #50121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

deps: update nghttp2 to 1.57.0 #50121

merged 1 commit into from
Oct 11, 2023

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 10, 2023

No description provided.

@jasnell jasnell requested review from RafaelGSS and mcollina October 10, 2023 14:55
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 10, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jasnell jasnell force-pushed the update-nghttp2-1.57.0 branch from 7979e0c to 037ed4f Compare October 10, 2023 15:02
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell mentioned this pull request Oct 10, 2023
Closed
@jasnell jasnell force-pushed the update-nghttp2-1.57.0 branch from 037ed4f to d14b7ac Compare October 10, 2023 15:09
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54669/

mhdawson
mhdawson approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@mcollina
Copy link
Member

I recommend fast tracking this

@mcollina mcollina added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 10, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

Trott
Trott approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

marco-ippolito
marco-ippolito approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any reason for manually updating rather than waiting for the action?

@jasnell
Copy link
Member Author

jasnell commented Oct 10, 2023

any reason for manually updating rather than waiting for the action?

The action misses the addition of new files to the source list in the gyp file

@jasnell
Copy link
Member Author

jasnell commented Oct 10, 2023

Looks like CI is having some of it's typical issues. I'm going to be tied up for a bit if someone else could please help babysit CI to get this landed as soon as it's ready.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54677/

@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Open
30 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54693/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit dc1c50b into nodejs:main Oct 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in dc1c50b

richardlau pushed a commit that referenced this pull request Oct 11, 2023
@jasnell @richardlau
deps: update nghttp2 to 1.57.0
24b09a4 
PR-URL: #50121
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@jasnell @RafaelGSS
deps: update nghttp2 to 1.57.0
c86883e 
PR-URL: nodejs/node#50121
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
CVE-ID: CVE-2023-44487
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
Closed
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 5, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 12, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 19, 2025
Closed
@sajjaphani sajjaphani mentioned this pull request May 19, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 26, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 2, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 9, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jul 8, 2025
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jul 21, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 18, 2025
Closed
Closed
This was referenced Sep 1, 2025
Closed
Closed
This was referenced Sep 15, 2025
Closed
Closed
This was referenced Sep 29, 2025
Closed
Closed
This was referenced Oct 13, 2025
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 20, 2025
Closed
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@jasnell @nodejs-github-bot @mcollina @F1r3Hydr4nt @OZZlE @richardlau @Trott @tniessen @mhdawson @marco-ippolito