From 027d26e0e7d402ea6579ac12b5e2b3d4e6f53f26 Mon Sep 17 00:00:00 2001 From: Rob Hogan <2590098+robhogan@users.noreply.github.com> Date: Sun, 23 Jun 2024 11:19:12 +0100 Subject: [PATCH 1/4] doc: note http.closeAllConnections excludes upgraded sockets --- doc/api/http.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/api/http.md b/doc/api/http.md index 0427dfff6123cb..a5fd9add59a27b 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -1705,8 +1705,10 @@ setTimeout(() => { added: v18.2.0 --> -Closes all connections connected to this server, including active connections -connected to this server which are sending a request or waiting for a response. +Closes all established HTTP(S) connections connected to this server, including +active connections connected to this server which are sending a request or +waiting for a response. Note that this does not destroy sockets upgraded to a +different protocol, such as WebSocket. > This is a forceful way of closing all connections and should be used with > caution. Whenever using this in conjunction with `server.close`, calling this From a64afc782e601c2ffe942593a6586da3871890e1 Mon Sep 17 00:00:00 2001 From: Rob Hogan <2590098+robhogan@users.noreply.github.com> Date: Sun, 23 Jun 2024 11:31:29 +0100 Subject: [PATCH 2/4] lint --- doc/api/http.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/http.md b/doc/api/http.md index a5fd9add59a27b..46a45b80df7493 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -1707,8 +1707,8 @@ added: v18.2.0 Closes all established HTTP(S) connections connected to this server, including active connections connected to this server which are sending a request or -waiting for a response. Note that this does not destroy sockets upgraded to a -different protocol, such as WebSocket. +waiting for a response. This does *not* destroy sockets upgraded to a different +protocol, such as WebSocket. > This is a forceful way of closing all connections and should be used with > caution. Whenever using this in conjunction with `server.close`, calling this From edfd92a87d82d40a54f86091e91bf0b89d1124f5 Mon Sep 17 00:00:00 2001 From: Rob Hogan <2590098+robhogan@users.noreply.github.com> Date: Sun, 23 Jun 2024 11:39:46 +0100 Subject: [PATCH 3/4] lint emphasis --- doc/api/http.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/http.md b/doc/api/http.md index 46a45b80df7493..9ee6f10197a6ef 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -1707,7 +1707,7 @@ added: v18.2.0 Closes all established HTTP(S) connections connected to this server, including active connections connected to this server which are sending a request or -waiting for a response. This does *not* destroy sockets upgraded to a different +waiting for a response. This does _not_ destroy sockets upgraded to a different protocol, such as WebSocket. > This is a forceful way of closing all connections and should be used with From 9c9ff849318b7e465e50ca391d77543c42586c86 Mon Sep 17 00:00:00 2001 From: Rob Hogan <2590098+robhogan@users.noreply.github.com> Date: Sun, 23 Jun 2024 11:48:06 +0100 Subject: [PATCH 4/4] add "or HTTP/2" --- doc/api/http.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/http.md b/doc/api/http.md index 9ee6f10197a6ef..3557e22085f8f7 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -1708,7 +1708,7 @@ added: v18.2.0 Closes all established HTTP(S) connections connected to this server, including active connections connected to this server which are sending a request or waiting for a response. This does _not_ destroy sockets upgraded to a different -protocol, such as WebSocket. +protocol, such as WebSocket or HTTP/2. > This is a forceful way of closing all connections and should be used with > caution. Whenever using this in conjunction with `server.close`, calling this