From 43e701461c94a7398795452a408e41685d4b7ab6 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 6 Jan 2025 19:49:07 +0100 Subject: [PATCH] doc: allow request for TSC reviews via the GitHub UI --- doc/contributing/collaborator-guide.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index eb5ab19f8923e9..e153c86061bb7d 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -523,7 +523,6 @@ deprecation level of an API. Collaborators can opt to elevate pull requests or issues to the [TSC][]. Do this if a pull request or issue: -* Is labeled `semver-major`, or * Has a significant impact on the codebase, or * Is controversial, or * Is at an impasse among collaborators who are participating in the discussion. @@ -532,6 +531,9 @@ Do this if a pull request or issue: [TSC][]. Do not use the GitHub UI on the right-hand side to assign to `@nodejs/tsc` or request a review from `@nodejs/tsc`. +If a pull request is labeled `semver-major`, you can request a review from the +`@nodejs/tsc` GitHub team. + The TSC serves as the final arbiter where required. ## Landing pull requests