From ecd4362784b180ea360feaf7c16ea5d3175c7fe2 Mon Sep 17 00:00:00 2001 From: theanarkh Date: Sun, 6 Jul 2025 17:34:28 +0800 Subject: [PATCH] dns: fix parse memory leaky --- src/cares_wrap.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index b32dd42f57ff74..7773314fa53bc1 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -1565,6 +1565,8 @@ Maybe SoaTraits::Parse(QuerySoaWrap* wrap, if (status != ARES_SUCCESS) return Just(status); + auto cleanup = OnScopeLeave([&]() { ares_free_data(soa_out); }); + Local soa_record = Object::New(env->isolate()); if (soa_record @@ -1605,8 +1607,6 @@ Maybe SoaTraits::Parse(QuerySoaWrap* wrap, return Nothing(); } - ares_free_data(soa_out); - wrap->CallOnComplete(soa_record); return Just(ARES_SUCCESS); }