From 8d620189cf085f370d50e6e9ab0af6373076673e Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Sat, 26 Jul 2025 14:53:55 -0300 Subject: [PATCH 1/2] benchmark: remove deprecated _extend from benchmark Signed-off-by: RafaelGSS --- benchmark/es/spread-assign.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/benchmark/es/spread-assign.js b/benchmark/es/spread-assign.js index f0dcd56bb606b1..1350cc5d147447 100644 --- a/benchmark/es/spread-assign.js +++ b/benchmark/es/spread-assign.js @@ -1,15 +1,15 @@ 'use strict'; const common = require('../common.js'); -const util = require('util'); +const assert = require('node:assert'); const bench = common.createBenchmark(main, { - method: ['spread', 'assign', '_extend'], + method: ['spread', 'assign'], count: [5, 10, 20], n: [1e6], }); -function main({ n, context, count, rest, method }) { +function main({ n, count, method }) { const src = {}; for (let n = 0; n < count; n++) @@ -18,12 +18,6 @@ function main({ n, context, count, rest, method }) { let obj; switch (method) { - case '_extend': - bench.start(); - for (let i = 0; i < n; i++) - obj = util._extend({}, src); - bench.end(n); - break; case 'assign': bench.start(); for (let i = 0; i < n; i++) @@ -33,10 +27,11 @@ function main({ n, context, count, rest, method }) { case 'spread': bench.start(); for (let i = 0; i < n; i++) - obj = { ...src }; // eslint-disable-line no-unused-vars + obj = { ...src }; bench.end(n); break; default: throw new Error('Unexpected method'); } + assert.ok(obj); } From c6c2fb5a95944616c2b58dd498f4ec3393c84a07 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Mon, 11 Aug 2025 11:42:16 -0300 Subject: [PATCH 2/2] fixup! benchmark: remove deprecated _extend from benchmark --- benchmark/es/spread-assign.js | 37 ----------------------------------- 1 file changed, 37 deletions(-) delete mode 100644 benchmark/es/spread-assign.js diff --git a/benchmark/es/spread-assign.js b/benchmark/es/spread-assign.js deleted file mode 100644 index 1350cc5d147447..00000000000000 --- a/benchmark/es/spread-assign.js +++ /dev/null @@ -1,37 +0,0 @@ -'use strict'; - -const common = require('../common.js'); -const assert = require('node:assert'); - -const bench = common.createBenchmark(main, { - method: ['spread', 'assign'], - count: [5, 10, 20], - n: [1e6], -}); - -function main({ n, count, method }) { - - const src = {}; - for (let n = 0; n < count; n++) - src[`p${n}`] = n; - - let obj; - - switch (method) { - case 'assign': - bench.start(); - for (let i = 0; i < n; i++) - obj = Object.assign({}, src); - bench.end(n); - break; - case 'spread': - bench.start(); - for (let i = 0; i < n; i++) - obj = { ...src }; - bench.end(n); - break; - default: - throw new Error('Unexpected method'); - } - assert.ok(obj); -}