From 1edf1ad779977cd7bb678ffed92462f7ce008e45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 28 Aug 2025 11:44:11 +0200 Subject: [PATCH 1/2] test: fix internet/test-dns The `nodejs.org` domain has now two TXT records. Do not verify the exact number of records returned (only their shape), and check that one of them is the SPF. --- test/internet/test-dns.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js index 538d49064799e5..1f27b52e478698 100644 --- a/test/internet/test-dns.js +++ b/test/internet/test-dns.js @@ -523,9 +523,9 @@ TEST(function test_resolveTlsa_failure(done) { TEST(async function test_resolveTxt(done) { function validateResult(result) { - assert.ok(Array.isArray(result[0])); - assert.strictEqual(result.length, 1); - assert(result[0][0].startsWith('v=spf1')); + assert.ok(result.length > 0); + assert.ok(result.every(elem => Array.isArray(elem) && elem.length === 1)); + assert.ok(result.some(elem => elem[0].startsWith('v=spf1'))); } validateResult(await dnsPromises.resolveTxt(addresses.TXT_HOST)); From 94614527e4e5a24ebece12838d3880346970b951 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 28 Aug 2025 11:49:19 +0200 Subject: [PATCH 2/2] lint --- test/internet/test-dns.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js index 1f27b52e478698..5299fd6e7dbcdd 100644 --- a/test/internet/test-dns.js +++ b/test/internet/test-dns.js @@ -524,8 +524,8 @@ TEST(function test_resolveTlsa_failure(done) { TEST(async function test_resolveTxt(done) { function validateResult(result) { assert.ok(result.length > 0); - assert.ok(result.every(elem => Array.isArray(elem) && elem.length === 1)); - assert.ok(result.some(elem => elem[0].startsWith('v=spf1'))); + assert.ok(result.every((elem) => Array.isArray(elem) && elem.length === 1)); + assert.ok(result.some((elem) => elem[0].startsWith('v=spf1'))); } validateResult(await dnsPromises.resolveTxt(addresses.TXT_HOST));