From a5ec48132d29d8f7a1e69db908717337b5389d30 Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Wed, 22 Oct 2025 10:14:56 -0400 Subject: [PATCH 1/2] test: increase debugger waitFor timeout on macOS --- test/common/debugger.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/common/debugger.js b/test/common/debugger.js index 1a258913e00dd7..78924cfe9a6111 100644 --- a/test/common/debugger.js +++ b/test/common/debugger.js @@ -7,12 +7,10 @@ const BREAK_MESSAGE = new RegExp('(?:' + [ 'exception', 'other', 'promiseRejection', 'step', ].join('|') + ') in', 'i'); -// Some macOS machines require more time to receive the outputs from the client. let TIMEOUT = common.platformTimeout(10000); -if (common.isWindows) { - // Some of the windows machines in the CI need more time to receive - // the outputs from the client. - // https://github.com/nodejs/build/issues/3014 +// Some macOS and Windows machines require more time to receive the outputs from the client. +// https://github.com/nodejs/build/issues/3014 +if (common.isWindows || common.isMacOS) { TIMEOUT = common.platformTimeout(15000); } From 672c34a6b49eb1884e9a04d8b78e8b87e64fe47b Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Wed, 22 Oct 2025 10:47:50 -0400 Subject: [PATCH 2/2] fixup! test: increase debugger waitFor timeout on macOS Co-authored-by: Colin Ihrig --- test/common/debugger.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common/debugger.js b/test/common/debugger.js index 78924cfe9a6111..f5a47cbe06ea71 100644 --- a/test/common/debugger.js +++ b/test/common/debugger.js @@ -8,7 +8,7 @@ const BREAK_MESSAGE = new RegExp('(?:' + [ ].join('|') + ') in', 'i'); let TIMEOUT = common.platformTimeout(10000); -// Some macOS and Windows machines require more time to receive the outputs from the client. +// Some macOS and Windows machines require more time to receive the outputs from the client. // https://github.com/nodejs/build/issues/3014 if (common.isWindows || common.isMacOS) { TIMEOUT = common.platformTimeout(15000);