From 57bbbfe6c83b165dceeb754cb8f2e2c4f61a091d Mon Sep 17 00:00:00 2001 From: Manoj Patel Date: Wed, 27 Jul 2016 21:48:17 -0700 Subject: [PATCH] src: --inspector notify contextDestroyed When node script execution finishes, inspector sends Runtime.contextDestroyed event over websocket. V8Inspector changes will be also sent to chromium repo. --- .../platform/v8_inspector/public/V8Inspector.cpp | 5 +++++ .../v8_inspector/platform/v8_inspector/public/V8Inspector.h | 1 + src/inspector_agent.cc | 1 + 3 files changed, 7 insertions(+) diff --git a/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.cpp b/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.cpp index f118dcacf3ce5a..c32c5df4d1fc6d 100644 --- a/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.cpp +++ b/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.cpp @@ -71,4 +71,9 @@ bool V8Inspector::canExecuteScripts() return true; } +void V8Inspector::notifyContextDestroyed() +{ + m_debugger->contextDestroyed(m_context); +} + } // namespace blink diff --git a/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.h b/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.h index 4dbb797d50935f..a7d3d6b2d2eda1 100644 --- a/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.h +++ b/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.h @@ -33,6 +33,7 @@ class V8Inspector : public V8DebuggerClient, V8InspectorSessionClient { void connectFrontend(protocol::FrontendChannel*); void disconnectFrontend(); void dispatchMessageFromFrontend(const String16& message); + void notifyContextDestroyed(); private: bool callingContextCanAccessContext(v8::Local calling, v8::Local target) override; diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 66928e09b114c0..6a8e15193e0637 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -381,6 +381,7 @@ bool AgentImpl::IsStarted() { void AgentImpl::WaitForDisconnect() { shutting_down_ = true; fprintf(stderr, "Waiting for the debugger to disconnect...\n"); + inspector_->notifyContextDestroyed(); inspector_->runMessageLoopOnPause(0); }