Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@jongwooo
Copy link
Contributor

Signed-off-by: jongwooo [email protected]

Description

Added missing banner image.

Related Issues

#3044

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@codecov-commenter
Copy link

Codecov Report

Base: 66.02% // Head: 68.07% // Increases project coverage by +2.05% 🎉

Coverage data is based on head (77b413b) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3047      +/-   ##
==========================================
+ Coverage   66.02%   68.07%   +2.05%     
==========================================
  Files         118      145      +27     
  Lines        1351     1654     +303     
  Branches      342      388      +46     
==========================================
+ Hits          892     1126     +234     
- Misses        422      485      +63     
- Partials       37       43       +6     
Impacted Files Coverage Δ
src/templates/blog.tsx 0.00% <0.00%> (-100.00%) ⬇️
util-node/getNodeReleasesData.js 91.30% <0.00%> (-6.32%) ⬇️
src/__fixtures__/page.tsx 94.11% <0.00%> (-5.89%) ⬇️
src/pages/index.tsx 100.00% <0.00%> (ø)
src/templates/api.tsx 0.00% <0.00%> (ø)
src/templates/learn.tsx 100.00% <0.00%> (ø)
util-node/createSlug.js 100.00% <0.00%> (ø)
util-node/getNvmData.js 100.00% <0.00%> (ø)
src/hooks/useOnScreen.tsx 100.00% <0.00%> (ø)
src/pages/about/index.tsx 100.00% <0.00%> (ø)
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovflowd ovflowd added Infrastructure Infra related task fast track labels Nov 30, 2022
@ovflowd ovflowd merged commit e31da70 into nodejs:main Nov 30, 2022
@jongwooo jongwooo deleted the hotfix/add-missing-banner-image branch November 30, 2022 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants