Commit 6be3b25
authored
fix: download button pointing to an incorrect binary on Windows arm64 (#7240)
* Fix Download button pointing to an incorrect binary on Windows arm64
Closes #7239
This PR changes the way DownloadButton calculates `bitness` which gets passed to `getNodeDownloadUrl`.
Previously, this value was passed directly from `useDetectOS()` without any further processing, leading to the issue mentioned above.
After this change, `bitness` is calculated similarly to how it's done in `BitnessDropdown`, so: by passing `architecture` and `bitness` to `getUserBitnessByArchitecture`:
https://github.com/nodejs/nodejs.org/blob/c5345f551ea545cf9d04017204b17f3099940ada/apps/site/components/Downloads/Release/BitnessDropdown.tsx#L16-L29
Signed-off-by: Wojciech Maj <[email protected]>
* Fix formatting
---------
Signed-off-by: Wojciech Maj <[email protected]>1 parent 52e04b0 commit 6be3b25
1 file changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
21 | 27 | | |
22 | 28 | | |
23 | 29 | | |
| |||
0 commit comments