Skip to content

Conversation

@watson
Copy link
Member

@watson watson commented Nov 22, 2017

No description provided.

@watson
Copy link
Member Author

watson commented Nov 22, 2017

I'm not sure how I18n works in this repo. Should I add this to all the other languages as well as part of this commit?

@lpinca
Copy link
Member

lpinca commented Nov 22, 2017

@watson yes, that would be great.

Ref: #1108

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watson
Copy link
Member Author

watson commented Nov 22, 2017

Will this be squashed when merged, or should I do it my self? (Used the github web editor, otherwise I would have amended)

@lpinca
Copy link
Member

lpinca commented Nov 22, 2017

Yes it will be squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants