Skip to content

Add missing check for predicate in primitive collection simplifications #3196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Add missing check for predicate in primitive collection simplifications #3196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/EFCore.PG/Query/Internal/NpgsqlQueryableMethodTranslatingExpressionVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,7 @@ static IEnumerable<INavigation> GetAllNavigationsInHierarchy(IEntityType entityT
Source1:
{
Tables: [PgUnnestExpression { Array: var array1 }],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand All @@ -560,6 +561,7 @@ static IEnumerable<INavigation> GetAllNavigationsInHierarchy(IEntityType entityT
Source2:
{
Tables: [PgUnnestExpression { Array: var array2 }],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand Down Expand Up @@ -676,6 +678,7 @@ static IEnumerable<INavigation> GetAllNavigationsInHierarchy(IEntityType entityT
&& source.QueryExpression is SelectExpression
{
Tables: [PgUnnestExpression { Array: var array }],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand Down Expand Up @@ -715,6 +718,7 @@ protected override ShapedQueryExpression TranslateConcat(ShapedQueryExpression s
if (source1.QueryExpression is SelectExpression
{
Tables: [PgUnnestExpression { Array: var array1 } unnestExpression1],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand All @@ -725,6 +729,7 @@ protected override ShapedQueryExpression TranslateConcat(ShapedQueryExpression s
&& source2.QueryExpression is SelectExpression
{
Tables: [PgUnnestExpression { Array: var array2 }],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand Down Expand Up @@ -788,6 +793,7 @@ [new PgUnnestExpression(tableAlias, _sqlExpressionFactory.Add(array1, array2), "
&& source.QueryExpression is SelectExpression
{
Tables: [PgUnnestExpression { Array: var array }],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand Down Expand Up @@ -918,6 +924,7 @@ [new PgUnnestExpression(tableAlias, _sqlExpressionFactory.Add(array1, array2), "
if (source.QueryExpression is SelectExpression
{
Tables: [PgUnnestExpression { Array: var array } unnestExpression],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand Down Expand Up @@ -980,6 +987,7 @@ [new PgUnnestExpression(tableAlias, _sqlExpressionFactory.Add(array1, array2), "
if (source.QueryExpression is SelectExpression
{
Tables: [PgUnnestExpression { Array: var array } unnestExpression],
Predicate: null,
GroupBy: [],
Having: null,
IsDistinct: false,
Expand Down