Skip to content

Commit c035821

Browse files
committed
fixup! address PR review comments
1 parent 3fba006 commit c035821

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

lib/commands/completion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ const dumpScript = async () => {
212212
// Really, one should not be tossing away EPIPE errors, or any
213213
// errors, so casually. But, without this, `. <(npm completion)`
214214
// can never ever work on OS X.
215-
// Ignoring coverage, see 'non EPIPE errors cause failures' test.
215+
// TODO Ignoring coverage, see 'non EPIPE errors cause failures' test.
216216
/* istanbul ignore next */
217217
if (er.errno === 'EPIPE')
218218
res()

lib/npm.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class Npm extends EventEmitter {
154154
}
155155
}
156156

157-
load () {
157+
async load () {
158158
if (!this.loadPromise) {
159159
process.emit('time', 'npm:load')
160160
this.log.pause()

lib/utils/npm-usage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Configuration fields: npm help 7 config
3131
npm@${npm.version} ${dirname(dirname(__dirname))}`
3232
}
3333

34-
const allCommands = (npm) => {
34+
const allCommands = async (npm) => {
3535
if (npm.config.get('long'))
3636
return usages(npm)
3737
return ('\n ' + wrap(cmdList))

test/fixtures/sandbox.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,6 @@ class Sandbox extends EventEmitter {
292292

293293
const cmd = this[_npm].argv.shift()
294294
return this[_npm].exec(cmd, this[_npm].argv)
295-
// const cmd = this[_npm].argv.shift()
296-
// const impl = await this[_npm].cmd(cmd)
297-
298-
// return impl.exec(this[_npm].argv)
299295
}
300296

301297
async complete (command, argv, partial) {

0 commit comments

Comments
 (0)