[tests] separate tests from linting and license validation #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emphasizing them like we do everywhere else to fix encoding errors and for consistency. Also removed the `<String>` from the type definition as we don't do that anywhere else. PR-URL: npm#2662 Credit: @ethomson Close: npm#2662 Reviewed-by: @wraithgar
This brought in @npmcli/[email protected] from commit e1822cf
This pulls in, installs, and de-dupes our subdependencies. Notable updates are promise-retry and @npmcli/move-file which had new versions but we had no way to update and/or dedupe We also manually removed uuid from our package.json which was only added in the past to try to get around this same deduping issue
This decouples our tests from depending on the node version being right, and allows us to run in all of the environments we need to during CI. PR-URL: npm#2681 Credit: @ljharb Close: npm#2681 Reviewed-by: @wraithgar
wraithgar
approved these changes
Feb 12, 2021
PR-URL: npm#2682 Credit: @ljharb Close: npm#2682 Reviewed-by: @wraithgar
wraithgar
added
Release 7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out from #2654.