Optional appropriate environ replace #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This needs tests and some documentation to explain what the feature is and how it works. |
isaacs
suggested changes
Jul 2, 2019
Contributor
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
Bug in the \ handling logic, and definitely needs a test and update to the docs.
| esc = failbackMatch[1] | ||
| esc = esc.length && esc.length % 2 | ||
| if (esc) continue | ||
| failback = name.slice(failbackMatch.index + 1) |
Contributor
There was a problem hiding this comment.
If you have an even number of \ chars, then this will be the wrong offset. https://gist.github.com/isaacs/c2b12db30a49324325a3781302668408
I recommend writing the failback parsing logic as a new npm module, so that it can get proper tests and documentation.
Contributor
|
@gucong3000 appreciate the contribution; That said, this seems to have some caveats to the implementation & looks fairly nuanced in terms of usage. I'm going to close this for now. |
This was referenced Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this PR, we can use a cross-platform configuration items in the
.npmrcfile: