feat: use macos-(latest|13) based on node version #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/huge-uninterested-bear
branch
from
65e1d99 to
75b2cbc
Compare
lukekarrys
changed the title
fritzy
approved these changes
May 2, 2024
Contributor
fritzy
left a comment
fritzy
left a comment
There was a problem hiding this comment.
Interesting! I'd like a little bit more context in the PR description/comment. Looks good!
Merged
Contributor
Author
|
@fritzy good call, landed it with some more context in the commit and PR body 👍 |
lukekarrys
pushed a commit
that referenced
this pull request
May 3, 2024
🤖 I have created a release *beep* *boop* --- ## [4.22.0](v4.21.4...v4.22.0) (2024-05-03) ### Features * [`21c9262`](21c9262) [#440](#440) use macos-(latest|13) based on node version (#440) (@lukekarrys) ### Bug Fixes * [`8b2e738`](8b2e738) [#432](#432) remove custom node-workspace plugin (@lukekarrys) * [`0df268d`](0df268d) [#442](#442) properly check for diff with multiple files from overwrite:false (#442) (@lukekarrys) * [`2eca24b`](2eca24b) [#441](#441) use git+https protocol for repo url (#441) (@lukekarrys) * [`732dddc`](732dddc) [#439](#439) update actions workflow versions (#439) (@lukekarrys) * [`7949ec3`](7949ec3) [#438](#438) add node 22 to CI matrix (#438) (@lukekarrys) * [`6d54cbf`](6d54cbf) [#436](#436) get correct exit code from npm publish/view (#436) (@lukekarrys) * [`d0bf7c2`](d0bf7c2) [#435](#435) update license (#435) (@lukekarrys) * [`df03d8b`](df03d8b) [#433](#433) dont create chore only PRs (#433) (@lukekarrys) ### Dependencies * [`dff1b5b`](dff1b5b) [#432](#432) bump release-please from 16.3.1 to 16.10.2 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jun 20, 2024
This was referenced Aug 6, 2024
Merged
This was referenced Aug 7, 2024
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macos-latestrecently switch to M1s which don't have Node builds for v14 and below. This change adds both macos-latest and macos-13 (which uses x86 cpus) and then excludes one or the other based on the Node version in the matrix. The result is still only one macOS CI job per Node version, but it will now use the correct CPU architecture per version.