feat: adds script to run tests with node 20 correctly #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Experimentation branches showing it couldn't work otherwise: npm/statusboard#1031, npm/abbrev-js#115 |
reggi
reviewed
Oct 27, 2025
owlstronaut
force-pushed
the
owlstronaut/test-globbing
branch
2 times, most recently
from
b115540 to
b7ee03d
Compare
reggi
reviewed
Oct 28, 2025
owlstronaut
force-pushed
the
owlstronaut/test-globbing
branch
from
b7ee03d to
92ba26b
Compare
reggi
approved these changes
Oct 29, 2025
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.28.0](v4.27.1...v4.28.0) (2025-10-29) ### Features * [`dccde95`](dccde95) [#537](#537) adds script to run tests with node 20 correctly (@owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because there are inconsistencies between node 20, 22, and 24. Here's my chart:
node --testnode --testnode --testnode --test testnode --test testnode --test testnode --test ./testnode --test ./testnode --test ./testnode --test ./test/**/*.jsnpm run testnode --test ./test/**/*.jsnode --test ./test/**/*.jsnode --test './test/**/*.js'node --test './test/**/*.js'node --test './test/**/*.js'node --test --experimental-test-coverage --test-timeout=3000 --test-coverage-lines=100 --test-coverage-functions=100 --test-coverage-branches=100 './test/**/*.js'node --test --experimental-test-coverage --test-timeout=3000 --test-coverage-lines=100 --test-coverage-functions=100 --test-coverage-branches=100 './test/**/*.js'node --test --experimental-test-coverage --test-timeout=3000 --test-coverage-lines=100 --test-coverage-functions=100 --test-coverage-branches=100 './test/**/*.js'Conclusion
The easiest thing to do is add a test script for v20 that we can remove when v20 is no longer supported.