fix(core): fix custom eslint rules with typescript 5.2 and ts-node as transpiler

[mattlewis92]

Current Behavior

Using custom eslint rules fails when using ts-node + typescript 5.2 due to moduleResolution being set to node16 for the workspace rules tsconfig, but then the module value is always being overridden to commonjs by instead of being preserved as node16. This worked in previous versions of typescript, but from 5.2 this becomes a hard error: microsoft/TypeScript#54567

Which is then swallowed and results in all custom eslint rules failing with a message like this:

1:1 error Definition for rule '@nx/workspace/rule-name' was not found

Expected Behavior

Linting with custom workspace rules works with ts-node + typescript 5.2

Related Issue(s)

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Feb 1, 2024 10:54am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 698a8cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=d1e842f8270ab4c224dbe352d1333ac884c05f7f --head=698a8cbae071bc6a9f958cc4da4850c9ca64ad56 --parallel=1
• nx affected --targets=lint,test,build --base=d1e842f8270ab4c224dbe352d1333ac884c05f7f --head=698a8cbae071bc6a9f958cc4da4850c9ca64ad56 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=d1e842f8270ab4c224dbe352d1333ac884c05f7f --head=698a8cbae071bc6a9f958cc4da4850c9ca64ad56
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=d1e842f8270ab4c224dbe352d1333ac884c05f7f --head=698a8cbae071bc6a9f958cc4da4850c9ca64ad56

---

Sent with 💌 from NxCloud.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2134ee9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --target=e2e --base=8762c38bb9f1bfcd66987baca486b0a6cdb9fa45 --head=2134ee900e4990fc072d5a878706393f0e27adff --parallel=1

✅ Successfully ran 5 targets

• nx affected --targets=lint,test,build --base=8762c38bb9f1bfcd66987baca486b0a6cdb9fa45 --head=2134ee900e4990fc072d5a878706393f0e27adff --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=8762c38bb9f1bfcd66987baca486b0a6cdb9fa45 --head=2134ee900e4990fc072d5a878706393f0e27adff
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=8762c38bb9f1bfcd66987baca486b0a6cdb9fa45 --head=2134ee900e4990fc072d5a878706393f0e27adff

---

Sent with 💌 from NxCloud.

[mattlewis92]

@meeroslav the CI failures are new after making this change, so I guess allowing setting the module option to anything would cause real breakages

Should the e2e tests be updated, or should I revert the change and go back to the tighter check?

[JamesHenry]

Hi @mattlewis92 I'm really sorry for how long it's taken for you to get a response on this one.

This area of the codebase has changed a little bit since this PR was opened and I just tried to reproduce the issue you are describing and couldn't.

I created a new nx workspace (therefore using TS 5.4), added a custom lint rule, wired it up in my eslint config, and ensured it was running with ts-node (not swc) by setting NX_PREFER_TS_NODE=true and everything worked fine.

I then deliberately made the lint rule fail with a bad import to make sure it wasn't a false positive.

Please could you provide steps to reproduce the issue with the latest nx?

[mattlewis92]

Hi @mattlewis92 I'm really sorry for how long it's taken for you to get a response on this one.

This area of the codebase has changed a little bit since this PR was opened and I just tried to reproduce the issue you are describing and couldn't.

I created a new nx workspace (therefore using TS 5.4), added a custom lint rule, wired it up in my eslint config, and ensured it was running with ts-node (not swc) by setting NX_PREFER_TS_NODE=true and everything worked fine.

I then deliberately made the lint rule fail with a bad import to make sure it wasn't a false positive.

Please could you provide steps to reproduce the issue with the latest nx?

All good, this has been fixed in the latest nx already by something else, we can close this :)

[JamesHenry]

Awesome, thank you for confirming!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.