fix: reliably dispatch exactly one TreeOpen and TreeClose events #3107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
TreeOpenandTreeCloseevent dispatch, per this discussion: #3105 (comment). Post this, both these events should only be dispatched exactly once in every case.Just to note, for
TreeClose, I found out while implementing that autocmd onWinCloseddoes not match with the file name. Instead it matches with the window ID, which we would not know (I think?).So instead, I had to write it as a condition in the callback to check the filetype of the underlying buffer to be
NvimTree. Do let me know if anything can be improved here.Any other thoughts on this ? @alex-courtis
Thanks!