Skip to content

Conversation

@wolfy1339
Copy link
Member

Fixes #969

Resolves #ISSUE_NUMBER


Before the change?

  • Some types did not represent the reality in the code

After the change?

  • The types better reflect the reality of the code

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Feb 11, 2024
@wolfy1339 wolfy1339 requested review from G-Rath and oscard0m February 11, 2024 21:33
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 enabled auto-merge (squash) February 15, 2024 02:48
@wolfy1339 wolfy1339 merged commit fb2db0b into main Feb 15, 2024
@wolfy1339 wolfy1339 deleted the fix-types branch February 15, 2024 02:49
@github-actions
Copy link
Contributor

🎉 This PR is included in version 12.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @beta released Type: Bug Something isn't working as documented, or is being fixed

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Type discrepencies vs actual code

5 participants