Skip to content

Conversation

@wolfy1339
Copy link
Member

This allows us to get errors when users pass payloads as objects and aren't using TypeScript

Resolves #ISSUE_NUMBER


Before the change?

  • Object payloads could be passed to the different methods with no error when not using TypeScript

After the change?

  • Object payloads will trigger an error at runtime if passed

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

This allows us to get errors when users pass payloads as objects and aren't using TypeScript
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 17, 2024
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 enabled auto-merge (squash) February 17, 2024 18:31
@wolfy1339 wolfy1339 merged commit d17d59c into main Feb 17, 2024
@wolfy1339 wolfy1339 deleted the update-webhooks-methods branch February 17, 2024 18:31
@github-actions
Copy link
Contributor

🎉 This PR is included in version 12.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @beta released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants