[FIX] account: Ref rounding of tax_details for better handling of price-included

== Fix bug price-included ==
Suppose a line of 24.99 with a 20% tax price-included.
base: 24.99 / 1.2 = 20.825
tax: 20.825 * 0.2 = 4.165
If we round both, we get 20.83 + 4.17 = 25.0 != 24.99

== Split and simplify round_base_line_tax_details ==
Easier implementation of this method to be easier to understand and
easier to be customized (see PT override). Also, we now use the
aggregate methods to aggregate the amounts instead of doing that by hand.

opw-4505888

closes odoo#232025

X-original-commit: e625fdb
Related: odoo/enterprise#97443
Signed-off-by: Antoine Dupuis (andu) <[email protected]>
Signed-off-by: Laurent Smet (las) <[email protected]>

Author: smetl

addons/account/models/account_tax.py

@@ -12,38 +12,56 @@ def test_dispatch_delta_on_base_lines(self):
         tax_21 = self.percent_tax(21.0)
         document = self.populate_document(self.init_document(
             lines=[
-                {'quantity': 1, 'price_unit': 10.04, 'discount': 10, 'tax_ids': tax_21},
+                {'price_unit': 10.04, 'discount': 10, 'tax_ids': tax_21},
             ] + [
-                {'quantity': 1, 'price_unit': 1.04, 'discount': 10, 'tax_ids': tax_21},
+                {'price_unit': 1.04, 'discount': 10, 'tax_ids': tax_21},
             ] * 10,
         ))
 
+        line_1_expected_values = {
+            'total_excluded': 9.04,
+            'total_excluded_currency': 9.04,
+            'total_included': 10.94,
+            'total_included_currency': 10.94,
+            'delta_total_excluded': 0.0,
+            'delta_total_excluded_currency': 0.0,
+            'taxes_data': [
+                {
+                    'tax_id': tax_21.id,
+                    'tax_amount': 1.88,
+                    'tax_amount_currency': 1.88,
+                    'base_amount': 9.02,
+                    'base_amount_currency': 9.02,
+                }
+            ],
+        }
+        line_2_expected_values = {
+            'total_excluded': 0.94,
+            'total_excluded_currency': 0.94,
+            'total_included': 1.14,
+            'total_included_currency': 1.14,
+            'delta_total_excluded': 0.0,
+            'delta_total_excluded_currency': 0.0,
+            'taxes_data': [
+                {
+                    'tax_id': tax_21.id,
+                    'tax_amount': 0.2,
+                    'tax_amount_currency': 0.2,
+                    'base_amount': 0.94,
+                    'base_amount_currency': 0.94,
+                }
+            ],
+        }
+
         expected_values = {
             'base_lines_tax_details': [
                 {
-                    'total_excluded': 9.04,
-                    'total_excluded_currency': 9.04,
-                    'total_included': 10.94,
-                    'total_included_currency': 10.94,
-                    'delta_total_excluded': -0.01,
-                    'delta_total_excluded_currency': -0.01,
-                    'taxes_data': [
-                        {
-                            'tax_id': tax_21.id,
-                            'tax_amount': 1.88,
-                            'tax_amount_currency': 1.88,
-                            'base_amount': 9.02,
-                            'base_amount_currency': 9.02,
-                        }
-                    ],
+                    **line_1_expected_values,
+                    'delta_total_excluded': -0.02,
+                    'delta_total_excluded_currency': -0.02,
                 },
-            ]
-            + 2 * [
                 {
-                    'total_excluded': 0.94,
-                    'total_excluded_currency': 0.94,
-                    'total_included': 1.14,
-                    'total_included_currency': 1.14,
+                    **line_2_expected_values,
                     'delta_total_excluded': -0.01,
                     'delta_total_excluded_currency': -0.01,
                     'taxes_data': [
@@ -56,45 +74,29 @@ def test_dispatch_delta_on_base_lines(self):
                         }
                     ],
                 },
-            ]
-            + [
                 {
-                    'total_excluded': 0.94,
-                    'total_excluded_currency': 0.94,
-                    'total_included': 1.14,
-                    'total_included_currency': 1.14,
+                    **line_2_expected_values,
                     'delta_total_excluded': -0.01,
                     'delta_total_excluded_currency': -0.01,
                     'taxes_data': [
                         {
                             'tax_id': tax_21.id,
-                            'tax_amount': 0.2,
-                            'tax_amount_currency': 0.2,
-                            'base_amount': 0.94,
-                            'base_amount_currency': 0.94,
+                            'tax_amount': 0.19,
+                            'tax_amount_currency': 0.19,
+                            'base_amount': 0.9299999999999999,
+                            'base_amount_currency': 0.9299999999999999,
                         }
                     ],
                 },
+                line_2_expected_values,
+                line_2_expected_values,
+                line_2_expected_values,
+                line_2_expected_values,
+                line_2_expected_values,
+                line_2_expected_values,
+                line_2_expected_values,
+                line_2_expected_values,
             ]
-            + 7 * [
-                {
-                    'total_excluded': 0.94,
-                    'total_excluded_currency': 0.94,
-                    'total_included': 1.14,
-                    'total_included_currency': 1.14,
-                    'delta_total_excluded': 0.0,
-                    'delta_total_excluded_currency': 0.0,
-                    'taxes_data': [
-                        {
-                            'tax_id': tax_21.id,
-                            'tax_amount': 0.2,
-                            'tax_amount_currency': 0.2,
-                            'base_amount': 0.94,
-                            'base_amount_currency': 0.94,
-                        }
-                    ],
-                },
-            ],
         }
 
         self.assert_base_lines_tax_details(document, expected_values)