[REF] point_of_sale, pos_*: improve tax computation in PoS

*: l10n_es_pos, l10n_sa_pos, point_of_sale, pos_discount,
  pos_loyalty, pos_razorpay, pos_restaurant, pos_self_order

Before this commit taxes computation was a mess in PoS, with differents
implementations in different places, and some of them not taking into
account all the complexity of the tax system (taxes included in price,
taxes on taxes, etc.).

This commit aims to unify all the tax computation logic in a single
place, and to make it more robust and easier to understand.

---

What's changes:

Rounding methods available in PoS are now:
1) Rounding applied only on cash payments
    In this case the remaining due is rounded only if there is at least
    one cash payment line and the remaining due is less than the
    rounding tolerance.

2) Rounding applied on all payment methods
    In this case the remaining due is always rounded even if a card
    payment method is used. The remaining due is rounded if it is less
    than the rounding tolerance. No payment method is rounded in this
    case, the whole order is rounded instead.

Taxes computation is now done globally on the order, and not on each
line. This way we ensure that the total tax amount is always correct,
even if there is some rounding issues on the lines.

---

Changes in tests:

`test_cash_rounding_down_add_invoice_line_not_only_round_cash_method_with_residual_rounding`
`test_cash_rounding_up_add_invoice_line_not_only_round_cash_method`

Are removed because the tested behavior is not longer present. Now when
rounding is enabled with only_round_cash_method=False, the whole order
is always rounded.

Accounting tests are now principally tested with Hoot instead of tours.

---

Developer note:

No prices should be calculated manually in the code base. Getters have
been created for this purpose in the following files:
- `product_template_accounting.js`
- `pos_order_accounting.js`
- `pos_order_line_accounting.js`

In the future, all PRs containing tax calculations must justify them.

closes odoo#229683

Taskid: 5143758
Related: odoo/enterprise#96123
Signed-off-by: David Monnom (moda) <[email protected]>

Author: davidmonnom

addons/l10n_es_pos/static/src/app/models/pos_order.js

@@ -6,7 +6,7 @@ patch(PosOrder.prototype, {
     canBeSimplifiedInvoiced() {
         return (
             this.config.is_spanish &&
-            roundCurrency(this.getTotalWithTax(), this.currency) <
+            roundCurrency(this.priceIncl, this.currency) <
                 this.company.l10n_es_simplified_invoice_limit
         );
     },

addons/l10n_fr_pos_cert/static/src/xml/OrderReceipt.xml

@@ -15,7 +15,7 @@
                     Old unit price:
                     <span class="oldPrice">
                         <s>
-                            <t t-out="formatCurrency(line.getTaxedlstUnitPrice())" /> / Units
+                            <t t-out="line.currencyDisplayPrice" /> / Units
                         </s>
                     </span>
                 </div>

addons/l10n_fr_pos_cert/static/src/xml/OrderSummary.xml

@@ -7,7 +7,7 @@
                     Old unit price:
                     <span class="oldPrice">
                         <s>
-                            <t t-esc="env.utils.formatCurrency(line.getTaxedlstUnitPrice())" /> / Units
+                            <t t-esc="line.currencyDisplayPrice" /> / Units
                         </s>
                     </span>
                 </li>

addons/l10n_fr_pos_cert/tests/test_hash.py

@@ -44,7 +44,7 @@ def test_hashes_should_be_equal_if_no_alteration(self):
         paid_order = {
             'access_token': False,
             'amount_paid': 20,
-            'amount_return': 5.0,
+            'amount_return': -5.0,
             'amount_tax': 0,
             'amount_total': 15.0,
             'date_order': fields.Datetime.to_string(fields.Datetime.now()),

addons/l10n_my_edi_pos/tests/test_myinvois_pos.py

@@ -469,6 +469,9 @@ def test_refund_constrains_consolidated_invoice(self):
                 # Fails, the order should be invoiced in such a case
                 with self.assertRaises(UserError):
                     self._create_order({
+                        'pos_order_ui_args': {
+                            'is_refund': True,
+                        },
                         'pos_order_lines_ui_args': [
                             {
                                 'product': self.product_one,
@@ -480,6 +483,9 @@ def test_refund_constrains_consolidated_invoice(self):
                 # If it is, it will work
                 self.invoicing_customer.vat = 'EI00000000010'
                 self._create_order({
+                    'pos_order_ui_args': {
+                        'is_refund': True,
+                    },
                     'pos_order_lines_ui_args': [
                         {
                             'product': self.product_one,
@@ -500,6 +506,9 @@ def test_refund_constrains_regular_invoice(self):
                 # Fails, the order should be invoiced in such a case
                 with self.assertRaises(UserError):
                     self._create_order({
+                        'pos_order_ui_args': {
+                            'is_refund': True,
+                        },
                         'pos_order_lines_ui_args': [
                             {
                                 'product': self.product_one,
@@ -510,6 +519,9 @@ def test_refund_constrains_regular_invoice(self):
                     })
                 # If invoicing is checked, it will work.
                 self._create_order({
+                    'pos_order_ui_args': {
+                        'is_refund': True,
+                    },
                     'pos_order_lines_ui_args': [
                         {
                             'product': self.product_one,
@@ -571,6 +583,9 @@ def test_consolidate_invoices_refund_with_customer(self):
             # We then create the refund for the order
             with self.with_pos_session(), patch(CONTACT_PROXY_METHOD, new=self._mock_successful_submission):
                 self._create_order({
+                    'pos_order_ui_args': {
+                        'is_refund': True,
+                    },
                     'pos_order_lines_ui_args': [
                         {
                             'product': self.product_one,
@@ -690,6 +705,9 @@ def test_consolidate_invoices_refund_export_xml(self):
             # We then create the refund for the first_order
             with self.with_pos_session(), patch(CONTACT_PROXY_METHOD, new=self._mock_successful_submission):
                 self._create_order({
+                    'pos_order_ui_args': {
+                        'is_refund': True,
+                    },
                     'pos_order_lines_ui_args': [
                         {
                             'product': product_1,

addons/l10n_sa_pos/static/src/overrides/models/pos_order.js

@@ -16,8 +16,8 @@ patch(PosOrder.prototype, {
                     company.name,
                     company.vat,
                     this.date_order,
-                    this.getTotalWithTax(),
-                    this.getTotalTax()
+                    this.priceIncl,
+                    this.amountTaxes
                 );
                 const qr_code_svg = new XMLSerializer().serializeToString(
                     codeWriter.write(qr_values, 200, 200)

addons/point_of_sale/models/pos_order.py

@@ -188,7 +188,7 @@ def _process_payment_lines(self, pos_order, order, pos_session, draft):
             return_payment_vals = {
                 'name': _('return'),
                 'pos_order_id': order.id,
-                'amount': -pos_order['amount_return'],
+                'amount': pos_order['amount_return'],
                 'payment_date': fields.Datetime.now(),
                 'payment_method_id': cash_payment_method.id,
                 'is_change': True,
@@ -209,7 +209,7 @@ def _prepare_tax_base_line_values(self):
     @api.model
     def _get_invoice_lines_values(self, line_values, pos_line, move_type):
         # correct quantity sign based on move type and if line is refund.
-        is_refund_order = pos_line.order_id.amount_total < 0.0
+        is_refund_order = pos_line.order_id.is_refund
         qty_sign = -1 if (
             (move_type == 'out_invoice' and is_refund_order)
             or (move_type == 'out_refund' and not is_refund_order)
@@ -847,8 +847,7 @@ def _prepare_invoice_vals(self):
         fiscal_position = self.fiscal_position_id
         pos_config = self.config_id
         rounding_method = pos_config.rounding_method
-        amount_total = sum(order.amount_total for order in self)
-        move_type = 'out_invoice' if amount_total >= 0 else 'out_refund'
+        move_type = 'out_invoice' if not any(order.is_refund for order in self) else 'out_refund'
         invoice_payment_term_id = (
             self.partner_id.property_payment_term_id.id
             if self.partner_id.property_payment_term_id and any(p.payment_method_id.type == 'pay_later' for p in self.payment_ids)

addons/point_of_sale/static/src/app/components/order_display/order_display.xml

@@ -27,18 +27,15 @@
                         <TagsList tags="getInternalNotes()"/>
                     </div>
                 </div>
-                <t t-set="taxTotals" t-value="order.taxTotals" />
-                <div t-if="taxTotals and props.mode !== 'receipt'" class="order-summary d-flex flex-column gap-1 p-2 border-bottom fw-bolder lh-sm">
-                    <div t-if="taxTotals.has_tax_groups" class="tax-info subentry d-flex justify-content-between w-100 fs-6 text-muted ">
+                <div t-if="props.mode !== 'receipt'" class="order-summary d-flex flex-column gap-1 p-2 border-bottom fw-bolder lh-sm">
+                    <div t-if="order.prices.taxDetails.has_tax_groups" class="tax-info subentry d-flex justify-content-between w-100 fs-6 text-muted ">
                         Taxes
                         <div id="order-widget-taxes">
-                            <span t-esc="formatCurrency(taxTotals.order_sign * taxTotals.tax_amount_currency)" class="tax"/>
+                            <span t-esc="order.currencyAmountTaxes" class="tax"/>
                         </div>
                     </div>
                     <div class="d-flex justify-content-between w-100 fs-3">
-                        Total
-                        <span t-esc="formatCurrency(taxTotals.order_sign * taxTotals.order_total)"
-                              class="total"/>
+                        Total <span t-esc="order.currencyDisplayPrice" class="total"/>
                     </div>
                 </div>
             </div>

addons/point_of_sale/static/src/app/components/orderline/orderline.js

@@ -27,27 +27,6 @@ export class Orderline extends Component {
         onLongPress: () => {},
     };
 
-    formatCurrency(amount) {
-        return formatCurrency(amount, this.line.currency.id);
-    }
-
-    get line() {
-        return this.props.line;
-    }
-
-    get taxGroup() {
-        return [
-            ...new Set(
-                this.line.product_id.taxes_id
-                    ?.map((tax) => tax.tax_group_id.pos_receipt_label)
-                    .filter((label) => label)
-            ),
-        ].join(" ");
-    }
-    getInternalNotes() {
-        return JSON.parse(this.line.note || "[]");
-    }
-
     setup() {
         this.root = useRef("root");
         if (this.props.mode === "display") {
@@ -69,4 +48,98 @@ export class Orderline extends Component {
             ]);
         }
     }
+
+    get line() {
+        return this.props.line;
+    }
+
+    get lineContainerClasses() {
+        return {
+            selected: this.line.isSelected() && this.props.mode === "display",
+            ...this.line.getDisplayClasses(),
+            ...(this.props.class || []),
+            "border-start": this.props.mode != "receipt" && this.line.combo_parent_id,
+            "orderline-combo fst-italic ms-4": this.line.combo_parent_id,
+            "position-relative d-flex align-items-center lh-sm cursor-pointer": true, // Keep all classes here
+        };
+    }
+
+    get lineClasses() {
+        const line = this.line;
+        const props = this.props;
+        if (line.combo_parent_id) {
+            return props.mode === "receipt" ? "px-2" : "p-2";
+        } else {
+            if (props.mode === "receipt") {
+                return line.combo_line_ids.length > 0 ? "" : "py-1";
+            } else {
+                return "p-2";
+            }
+        }
+    }
+
+    get infoListClasses() {
+        const line = this.line;
+        const props = this.props;
+        if (props.mode === "receipt") {
+            return "";
+        }
+        if (line.customer_note || line.note || line.discount || line.packLotLines?.length) {
+            return "gap-2 mt-1";
+        }
+        return "";
+    }
+
+    /**
+     * To avoid to much logic in the template, we compute all values here
+     * and use them in the template.
+     */
+    get lineScreenValues() {
+        const line = this.line;
+
+        // Prevent rendering if the line is not yet linked to an order
+        // this can happen during related models connections
+        if (!line.order_id) {
+            return {};
+        }
+
+        const imageUrl = line.product_id?.getImageUrl();
+        const basic = this.props.basic_receipt;
+        const unitPart = line.getQuantityStr().unitPart;
+        const decimalPart = line.getQuantityStr().decimalPart;
+        const decimalPoint = line.getQuantityStr().decimalPoint;
+        const discount = line.getDiscountStr();
+        const mode = this.props.mode;
+        const attributeStr = line.orderDisplayProductName.attributeString;
+        const taxGroup = [
+            ...new Set(
+                this.line.product_id.taxes_id
+                    ?.map((tax) => tax.tax_group_id.pos_receipt_label)
+                    .filter((label) => label)
+            ),
+        ].join(" ");
+        const showPrice =
+            !basic &&
+            line.getQuantityStr() != 1 &&
+            (mode === "receipt" || (line.price_type !== "original" && !line.combo_parent_id));
+        const priceUnit = `${line.currencyDisplayPriceUnit} / ${
+            line.product_id?.uom_id?.name || ""
+        }`;
+        return {
+            name: mode === "receipt" ? line.full_product_name : line.orderDisplayProductName.name,
+            attributeString: mode === "display" && attributeStr && `- ${attributeStr}`,
+            internalNote: mode === "display" && line.note && JSON.parse(this.line.note || "[]"),
+            isReceipt: mode === "receipt",
+            isDisplay: mode === "display",
+            discount: !basic && discount && discount !== "0" && !line.combo_parent_id && discount,
+            noDiscountPrice: formatCurrency(line.displayPriceNoDiscount, line.currency.id),
+            displayPriceUnit: showPrice && line.price !== 0 && priceUnit,
+            unitPart: unitPart,
+            decimalPart: decimalPart && `${decimalPoint}${decimalPart}`,
+            productImage: this.props.showImage && imageUrl,
+            taxGroup: this.props.showTaxGroup && taxGroup,
+            price: !basic && !line.combo_parent_id && this.line.currencyDisplayPrice,
+            lotLines: line.product_id.tracking !== "none" && (line.packLotLines || []),
+        };
+    }
 }