[IMP] voip: proxy provider

addons/account/models/account_bank_statement.py

@@ -94,6 +94,10 @@ class AccountBankStatement(models.Model):
         search='_search_is_valid',
     )
 
+    journal_has_invalid_statements = fields.Boolean(
+        related='journal_id.has_invalid_statements',
+    )
+
     problem_description = fields.Text(
         compute='_compute_problem_description',
     )

addons/account/models/account_bank_statement_line.py

@@ -474,6 +474,12 @@ def action_undo_reconciliation(self):
     # HELPERS
     # -------------------------------------------------------------------------
 
+    @api.ondelete(at_uninstall=False)
+    def _check_allow_unlink(self):
+        if self.statement_id.filtered(lambda stmt: stmt.is_valid and stmt.is_complete):
+            raise UserError(_("You can not delete a transaction from a valid statement.\n"
+                              "If you want to delete it, please remove the statement first."))
+
     def _find_or_create_bank_account(self):
         self.ensure_one()
 

addons/account/models/account_journal.py

@@ -264,6 +264,7 @@ def _get_default_account_domain(self):
     )
     accounting_date = fields.Date(compute='_compute_accounting_date')
     display_alias_fields = fields.Boolean(compute='_compute_display_alias_fields')
+    has_invalid_statements = fields.Boolean(compute='_compute_has_invalid_statements')
 
     show_fetch_in_einvoices_button = fields.Boolean(
         string="Show E-Invoice Buttons",
@@ -287,6 +288,16 @@ def _get_default_account_domain(self):
         'Journal codes must be unique per company.',
     )
 
+    def _compute_has_invalid_statements(self):
+        journals_with_invalid_statements = self.env['account.bank.statement'].search([
+            ('journal_id', 'in', self.ids),
+            '|',
+            ('is_valid', '=', False),
+            ('is_complete', '=', False),
+        ]).journal_id
+        journals_with_invalid_statements.has_invalid_statements = True
+        (self - journals_with_invalid_statements).has_invalid_statements = False
+
     def _compute_display_alias_fields(self):
         self.display_alias_fields = self.env['mail.alias.domain'].search_count([], limit=1)
 

addons/account/models/account_journal_dashboard.py

@@ -51,6 +51,7 @@ def _compute_last_bank_statement(self):
                       SELECT id, company_id
                         FROM account_bank_statement
                        WHERE journal_id = journal.id
+                         AND first_line_index IS NOT NULL
                     ORDER BY first_line_index DESC
                        LIMIT 1
                    ) statement ON TRUE
@@ -526,6 +527,11 @@ def _fill_bank_cash_dashboard_data(self, dashboard_data):
                 'image': '/account/static/src/img/bank.svg' if journal.type in ('bank', 'credit') else '/web/static/img/rfq.svg',
                 'text': _('Drop to import transactions'),
             }
+            last_statement_visible = (
+                not journal.company_id.fiscalyear_lock_date
+                or journal.last_statement_id.date
+                and journal.company_id.fiscalyear_lock_date < journal.last_statement_id.date
+            )
 
             dashboard_data[journal.id].update({
                 'number_to_check': number_to_check,
@@ -538,6 +544,8 @@ def _fill_bank_cash_dashboard_data(self, dashboard_data):
                 'nb_lines_outstanding_pay_account_balance': has_outstanding,
                 'last_balance': currency.format(journal.last_statement_id.balance_end_real),
                 'last_statement_id': journal.last_statement_id.id,
+                'last_statement_visible': last_statement_visible,
+                'has_invalid_statements': journal.has_invalid_statements,
                 'bank_statements_source': journal.bank_statements_source,
                 'is_sample_data': journal.has_statement_lines,
                 'nb_misc_operations': number_misc,
@@ -802,6 +810,7 @@ def _get_journal_dashboard_bank_running_balance(self):
                              FROM account_bank_statement
                             WHERE journal_id = journal.id
                               AND company_id = ANY(%s)
+                              AND first_line_index IS NOT NULL
                          ORDER BY date DESC, id DESC
                             LIMIT 1
                    ) statement ON TRUE
@@ -1119,6 +1128,10 @@ def open_bank_difference_action(self):
             }
         return action
 
+    def open_invalid_statements_action(self):
+        self.ensure_one()
+        return self.env["ir.actions.act_window"]._for_xml_id('account.action_bank_statement_tree')
+
     def _show_sequence_holes(self, domain):
         return {
             'type': 'ir.actions.act_window',

addons/account/models/account_move.py

@@ -3,6 +3,7 @@
 import ast
 import calendar
 from collections import Counter, defaultdict
+from collections.abc import Mapping
 from contextlib import ExitStack, contextmanager
 from datetime import date, timedelta
 from dateutil.relativedelta import relativedelta
@@ -1925,7 +1926,7 @@ def _compute_access_url(self):
         for move in self.filtered(lambda move: move.is_invoice()):
             move.access_url = '/my/invoices/%s' % (move.id)
 
-    @api.depends('move_type', 'partner_id', 'company_id')
+    @api.depends('move_type', 'partner_id', 'partner_id.lang', 'company_id')
     def _compute_narration(self):
         use_invoice_terms = self.env['ir.config_parameter'].sudo().get_bool('account.use_invoice_terms')
         invoice_to_update_terms = self.filtered(lambda m: use_invoice_terms and m.is_sale_document(include_receipts=True))
@@ -4848,7 +4849,7 @@ def tax_details_grouping_function(base_line, tax_data):
             for grouping_key, values in aggregated_values.items():
                 if not grouping_key:
                     continue
-                if isinstance(grouping_key, dict):
+                if isinstance(grouping_key, Mapping):
                     values.update(grouping_key)
                 tax_details[grouping_key] = values
 
@@ -4857,7 +4858,7 @@ def tax_details_grouping_function(base_line, tax_data):
         for grouping_key, values in values_per_grouping_key.items():
             if not grouping_key:
                 continue
-            if isinstance(grouping_key, dict):
+            if isinstance(grouping_key, Mapping):
                 values.update(grouping_key)
             tax_details[grouping_key] = values
 

addons/account/models/account_report.py

@@ -588,6 +588,7 @@ class AccountReportExpression(models.Model):
             ('account_codes', "Prefix of Account Codes"),
             ('external', "External Value"),
             ('custom', "Custom Python Function"),
+            ('text', "Plain Text"),
         ],
         required=True
     )

addons/account/models/chart_template.py

@@ -283,7 +283,8 @@ def _pre_reload_data(self, company, template_data, data, force_create=True, forc
         for prop in list(template_data):
             if prop.startswith('property_'):
                 template_data.pop(prop)
-        data.pop('account.reconcile.model', None)
+        if not force_update:
+            data.pop('account.reconcile.model', None)
         if 'res.company' in data and not force_update:
             data['res.company'][company.id].clear()
             data['res.company'][company.id].setdefault('anglo_saxon_accounting', company.anglo_saxon_accounting)
@@ -409,10 +410,11 @@ def tax_template_changed(tax, template):
                             if rename_idx:
                                 tax_to_rename.name = f"[old{rename_idx - 1 if rename_idx > 1 else ''}] {tax_to_rename.name}"
                     else:
-                        fiscal_position_ids = values.get('fiscal_position_ids')
-                        original_tax_ids = values.get('original_tax_ids')
-                        repartition_lines = values.get('repartition_line_ids')
-                        values.clear()
+                        fiscal_position_ids = values.pop('fiscal_position_ids', None)
+                        original_tax_ids = values.pop('original_tax_ids', None)
+                        repartition_lines = values.pop('repartition_line_ids', None)
+                        if not force_update:
+                            values.clear()
                         # taxes will always be (re)linked to fiscal positions (unless the fp doesn't exist and won't be created)
                         if fiscal_position_ids:
                             link_commands = [

addons/account/models/product.py

@@ -96,7 +96,7 @@ def _compute_tax_string(self):
 
     def _construct_tax_string(self, price):
         currency = self.currency_id
-        res = self.taxes_id.filtered(lambda t: t.company_id == self.env.company).compute_all(
+        res = self.taxes_id._filter_taxes_by_company(self.env.company).compute_all(
             price, product=self, partner=self.env['res.partner']
         )
         joined = []

addons/account/models/res_partner_bank.py

@@ -74,8 +74,10 @@ def _compute_duplicate_bank_partner_ids(self):
                   FROM res_partner_bank this
              LEFT JOIN res_partner_bank other ON this.acc_number = other.acc_number
                                              AND this.id != other.id
+                                             AND other.active = TRUE
                  WHERE this.id = ANY(%(ids)s)
                  AND other.partner_id IS NOT NULL
+                   AND this.active = TRUE
                    AND (
                         ((this.company_id = other.company_id) OR (this.company_id IS NULL AND other.company_id IS NULL))
                         OR

addons/account/static/tests/account_move_form.test.js

@@ -7,7 +7,7 @@ import {
     triggerHotkey,
 } from "@mail/../tests/mail_test_helpers";
 import { expect, test } from "@odoo/hoot";
-import { contains, onRpc } from "@web/../tests/web_test_helpers";
+import { contains, defineModels, fields, onRpc, models} from "@web/../tests/web_test_helpers";
 import { defineAccountModels } from "./account_test_helpers";
 
 defineAccountModels();
@@ -61,3 +61,63 @@ test("Confirmation dialog on delete contains a warning", async () => {
         { message: "warning message has been added in the dialog" }
     );
 });
+class AccountMove extends models.Model {
+    line_ids = fields.One2many({
+        string: "Invoice Lines",
+        relation: "account.move.line",
+    })
+
+    _records = [{ id: 1, name: "account.move" }]
+}
+class AccountMoveLine extends models.Model {
+    name = fields.Char();
+    product_id = fields.Many2one({
+        string:"Product",
+        relation:"product",
+    });
+    move_id = fields.Many2one({
+        string: "Account Move",
+        relation: "account.move",
+    })
+}
+class Product extends models.Model {
+    name = fields.Char();
+    _records = [{ id: 1, name: "testProduct" }];
+}
+
+defineModels({ Product, AccountMoveLine, AccountMove });
+
+test("Update description on product line", async() => {
+    const pyEnv = await startServer();
+    const productId = pyEnv["product"].browse([1]);
+    const accountMove = pyEnv["account.move"].browse([1]);
+    pyEnv["account.move.line"].create({ name: productId[0].name, product_id: productId[0].id, move_id: accountMove[0].id });
+    await start();
+    onRpc("account.move", "web_save", () => { expect.step("save")});
+    await openFormView("account.move", accountMove[0].id, {
+        arch: `<form js_class="account_move_form">
+            <sheet>
+                <notebook>
+                    <page id="invoice_tab" name="invoice_tab" string="Invoice Lines">
+                        <field name="invoice_line_ids" mode="list" widget="product_label_section_and_note_field_o2m">
+                            <list name="journal_items" editable="bottom" string="Journal Items">
+                                <field name="product_id" widget="product_label_section_and_note_field" readonly="0"/>
+                                <field name="name" widget="section_and_note_text" optional="show"/>
+                            </list>
+                        </field>
+                    </page>
+                </notebook>
+            </sheet>
+        </form>`,
+    });
+
+    await click(".o_many2one");
+    await contains("#labelVisibilityButtonId").click()
+    await insertText("textarea[placeholder='Enter a description']", "testDescription");
+    await click(".o_form_button_save");
+    await expect.waitForSteps(["save"]);
+
+    const line = pyEnv["account.move.line"].browse([1])[0];
+    expect(line.name).toBe("testProduct\ntestDescription");
+
+});

addons/account/tests/test_account_move_out_invoice.py

@@ -4733,6 +4733,32 @@ def test_narration_preserved_when_use_invoice_terms_disabled(self):
             "Narration should be preserved after partner change when invoice terms are disabled"
         )
 
+    def test_narration_translation_on_partner_language_change(self):
+        """Ensure narration translates when partner.lang changes (HTML terms link)."""
+        self.env['ir.config_parameter'].sudo().set_bool('account.use_invoice_terms', True)
+        self.env['res.lang']._activate_lang('fr_FR')
+
+        self.env.company.terms_type = 'html'
+
+        # Baseline: en_US user/partner
+        self.partner_a.lang = 'en_US'
+
+        # Create invoice
+        invoice = self.init_invoice(move_type='out_invoice', partner=self.partner_a)
+
+        baseurl = self.env.company.get_base_url() + '/terms'
+
+        # Check the initial narration is in English
+        expected_en = f"<p>Terms &amp; Conditions: {baseurl}</p>"
+        self.assertEqual(invoice.narration, expected_en)
+
+        # Switch to fr_FR
+        self.partner_a.lang = 'fr_FR'
+
+        # Check the narration is in French
+        expected_fr = f"<p>Conditions générales : {baseurl}</p>"
+        self.assertEqual(invoice.narration, expected_fr)
+
     def test_multiple_currency_change(self):
         """
         Test amount currency and balance are correctly recomputed when switching currency multiple times

addons/account/tests/test_duplicate_res_partner_bank.py

@@ -52,3 +52,7 @@ def test_remove_bank_account_from_partner(self):
             partner_form.bank_ids.remove(0)
 
         self.assertEqual(len(partner.bank_ids), 0)
+
+    def test_duplicate_acc_number_inactive_bank_account(self):
+        self.partner_bank_b.active = False
+        self.assertFalse(self.partner_bank_a.duplicate_bank_partner_ids)

addons/account/views/account_journal_dashboard_view.xml

@@ -257,7 +257,7 @@
                                     <span dir="ltr"><t t-out="dashboard.account_balance"/></span>
                                 </div>
                             </div>
-                            <t t-if="dashboard.has_at_least_one_statement and dashboard.account_balance != dashboard.last_balance">
+                            <t t-if="dashboard.has_at_least_one_statement and dashboard.account_balance != dashboard.last_balance and dashboard.last_statement_visible">
                                 <div class="row" name="latest_statement">
                                     <div class="col overflow-hidden text-start">
                                         <span title="Latest Statement">Last Statement</span>
@@ -290,6 +290,16 @@
                                 </div>
                             </div>
                             <t t-call="JournalChecks"/>
+                            <t t-if="dashboard.has_invalid_statements">
+                                <div class="row">
+                                    <a type="object"
+                                       name="open_invalid_statements_action"
+                                       title="Invalid Statement(s)"
+                                       class="text-danger">
+                                        Invalid Statement(s)
+                                    </a>
+                                </div>
+                            </t>
                         </div>
                     </t>
                     <t t-name="JournalBodySalePurchase" id="account.JournalBodySalePurchase">

addons/account/wizard/account_automatic_entry_wizard.py

@@ -241,7 +241,7 @@ def _get_move_dict_vals_change_account(self):
                     'partner_id': partner.id or None,
                     'currency_id': currency.id,
                     'amount_currency': (account_balance > 0 and -1 or 1) * abs(account_amount_currency),
-                    'analytic_distribution': analytic_distribution,
+                    'analytic_distribution': analytic_distribution and dict(analytic_distribution),
                 })
 
         # Get the lowest child company based on accounts used to avoid access error

addons/account_edi_ubl_cii/models/account_edi_xml_ubl_bis3.py

@@ -4,7 +4,7 @@
 
 from odoo import models, _
 from odoo.addons.account.tools import dict_to_xml
-from odoo.addons.account_edi_ubl_cii.models.account_edi_xml_ubl_20 import UBL_NAMESPACES
+from odoo.addons.account_edi_ubl_cii.models.account_edi_xml_ubl_20 import FloatFmt, UBL_NAMESPACES
 
 from stdnum.no import mva
 
@@ -290,8 +290,9 @@ def _add_document_line_tax_category_nodes(self, line_node, vals):
 
     def _add_document_line_price_nodes(self, line_node, vals):
         super()._add_document_line_price_nodes(line_node, vals)
-        if vals['base_line']['price_unit'] < 0.0:
-            line_node['cac:Price']['cbc:PriceAmount']['_text'] = -line_node['cac:Price']['cbc:PriceAmount']['_text']
+        currency_suffix = vals['currency_suffix']
+        sign = 1 if vals['base_line']['price_unit'] >= 0.0 else -1
+        line_node['cac:Price']['cbc:PriceAmount']['_text'] = FloatFmt(sign * vals[f'gross_price_unit{currency_suffix}'], 1, 8)
 
     # -------------------------------------------------------------------------
     # EXPORT: Constraints

addons/account_edi_ubl_cii/models/res_partner.py

@@ -26,8 +26,8 @@ class ResPartner(models.Model):
             ('ubl_bis3', "EU Standard (Peppol Bis 3.0)"),
             ('xrechnung', "Germany (XRechnung)"),
             ('nlcius', "Netherlands (NLCIUS)"),
-            ('ubl_a_nz', "Australia BIS Billing 3.0 A-NZ"),
-            ('ubl_sg', "Singapore BIS Billing 3.0 SG"),
+            ('ubl_a_nz', "Australia (BIS Billing 3.0 A-NZ)"),
+            ('ubl_sg', "Singapore (BIS Billing 3.0 SG)"),
         ],
     )
     is_ubl_format = fields.Boolean(compute='_compute_is_ubl_format')