Add reviewer guidelines #2966
Merged
Add reviewer guidelines #2966
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
approved these changes
Oct 24, 2025
lmolkova
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
arminru
approved these changes
Oct 28, 2025
joaopgrassi
approved these changes
Oct 28, 2025
trask
approved these changes
Oct 28, 2025
trisch-me
approved these changes
Oct 28, 2025
Co-authored-by: Armin Ruech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reviewer etiquette to the contributing doc.
TL;DR:
Reviewers that don't belong to the SIG should use their best judgement when reviewing.
Everybody should do their best to accompany suggestions with proof-links :)