Skip to content

Commit 1000ed6

Browse files
committed
Use debian-base instead of distroless for conformance image
The `diff` binary (required by the `kubectl diff` e2e test) gets statically or dynamically linked based on the used glibc version. We cannot really predict that behavior for the various platforms of debian-base and therefore cannot copy the binary around. This means that distroless is not a great choice for the conformance image unless we stop relying on `diff`. This means we now switch back to `debian-base` for the conformance image to simplify the build process and reduce the amount of moving parts. Signed-off-by: Sascha Grunert <[email protected]>
1 parent 90c362b commit 1000ed6

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

test/conformance/image/Dockerfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,9 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
ARG BASEIMAGE
1615
ARG RUNNERIMAGE
17-
18-
FROM ${BASEIMAGE} as debbase
19-
2016
FROM ${RUNNERIMAGE}
2117

22-
# This is a dependency for `kubectl diff` tests
23-
COPY --from=debbase /usr/bin/diff /usr/local/bin/
24-
COPY --from=debbase /lib/x86_64-linux-gnu/libc.so.6 /lib/x86_64-linux-gnu
25-
COPY --from=debbase /lib/x86_64-linux-gnu/libpthread.so.0 /lib/x86_64-linux-gnu
26-
COPY --from=debbase /lib64/ld-linux-x86-64.so.2 /lib64
27-
2818
COPY cluster /kubernetes/cluster
2919
COPY ginkgo /usr/local/bin/
3020
COPY e2e.test /usr/local/bin/

test/conformance/image/Makefile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,7 @@ CLUSTER_DIR?=$(shell pwd)/../../../cluster/
3434
# This is defined in root Makefile, but some build contexts do not refer to them
3535
KUBE_BASE_IMAGE_REGISTRY?=registry.k8s.io
3636
BASE_IMAGE_VERSION?=bookworm-v1.0.0
37-
BASEIMAGE?=${KUBE_BASE_IMAGE_REGISTRY}/build-image/debian-base-${ARCH}:${BASE_IMAGE_VERSION}
38-
39-
# Keep debian releases (e.g. debian 11 == bullseye) consistent
40-
# between BASE_IMAGE_VERSION and DISTROLESS_IMAGE images
41-
DISTROLESS_IMAGE?=base-debian11
42-
RUNNERIMAGE?=gcr.io/distroless/${DISTROLESS_IMAGE}:latest
37+
RUNNERIMAGE?=${KUBE_BASE_IMAGE_REGISTRY}/build-image/debian-base-${ARCH}:${BASE_IMAGE_VERSION}
4338

4439
TEMP_DIR:=$(shell mktemp -d -t conformance-XXXXXX)
4540

@@ -68,7 +63,6 @@ endif
6863
--load \
6964
--pull \
7065
-t ${REGISTRY}/conformance-${ARCH}:${VERSION} \
71-
--build-arg BASEIMAGE=$(BASEIMAGE) \
7266
--build-arg RUNNERIMAGE=$(RUNNERIMAGE) \
7367
${TEMP_DIR}
7468
rm -rf "${TEMP_DIR}"

0 commit comments

Comments
 (0)