Incorporate PR review feedback

Author: olpaw

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeJNIAccess.java

@@ -59,18 +59,22 @@
 public final class RuntimeJNIAccess {
 
     /**
-     * Makes the provided classes available for JNI access at run time. Needed when C/C++ code looks
-     * up Java classes via JNINativeInterface.FindClass, GetObjectClass or DefineClass.
-     * 
+     * Makes the provided classes available for JNI access at run time. Needed when native code
+     * looks up Java classes via <a href=
+     * "https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#findclass">FindClass</a>.
+     *
      * @since 22.3
      */
     public static void register(Class<?>... classes) {
         ImageSingletons.lookup(RuntimeJNIAccessSupport.class).register(ConfigurationCondition.alwaysTrue(), classes);
     }
 
     /**
-     * Makes the provided methods available for JNI access at run time. Needed when C/C++ code looks
-     * up Java methods via JNINativeInterface.GetMethodID or GetStaticMethodID.
+     * Makes the provided methods available for JNI access at run time. Needed when native code
+     * looks up Java methods via <a href=
+     * "https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#getmethodid">GetMethodID</a>
+     * or <a href=
+     * "https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#getstaticmethodid">GetStaticMethodID</a>.
      *
      * @since 22.3
      */
@@ -79,8 +83,11 @@ public static void register(Executable... methods) {
     }
 
     /**
-     * Makes the provided fields available for JNI access at run time. Needed when C/C++ code looks
-     * up Java fields via JNINativeInterface.GetFieldID or GetStaticFieldID.
+     * Makes the provided fields available for JNI access at run time. Needed when native code looks
+     * up Java fields via <a href=
+     * "https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#getfieldid">GetFieldID</a>
+     * or <a href=
+     * "https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#getstaticfieldid">GetStaticFieldID</a>.
      *
      * @since 22.3
      */

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeProxyCreation.java

@@ -54,8 +54,9 @@
 public final class RuntimeProxyCreation {
 
     /**
-     * Register dynamic proxy class that should be available to get created at run time. The proxy
-     * class is fully specified by the interfaces it implements.
+     * Enables registering specifications of {@link java.lang.reflect.Proxy} classes during the
+     * image build so that matching proxy objects can be created at runtime. The proxy class is
+     * fully specified by the interfaces it implements.
      *
      * @since 22.3
      */

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeResourceAccess.java

@@ -60,8 +60,8 @@ public final class RuntimeResourceAccess {
 
     /**
      * Make Java resources that are matched by a {@code pattern} available at run time. If the given
-     * {@code pattern} starts with {@code <module-name>:} then pattern that follows will only match
-     * resources coming from Java module named {@code <module-name>}.
+     * {@code pattern} starts with {@code <module-name>:} then the pattern that follows will only
+     * match resources from Java module named {@code <module-name>}.
      *
      * @since 22.3
      */
@@ -71,8 +71,8 @@ public static void includeResources(String pattern) {
 
     /**
      * Ensure Java resources that are matched by a {@code pattern} will never be available at run
-     * time. If the given {@code pattern} starts with {@code <module-name>:} then pattern that
-     * follows will only match resources coming from Java module named {@code <module-name>}.
+     * time. If the given {@code pattern} starts with {@code <module-name>:} then the pattern that
+     * follows will only match resources from Java module named {@code <module-name>}.
      *
      * @since 22.3
      */

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeSerialization.java

@@ -101,8 +101,9 @@ public static void registerWithTargetConstructorClass(Class<?> clazz, Class<?> c
     }
 
     /**
-     * Makes class available for serialization at runtime that is created for the lambda expressions
-     * (a class that has a $deserializeLambda$ method) specified by the lambdaCapturingClassName.
+     * Makes a class available for serialization at runtime that is created for the lambda
+     * expressions (a class that has a $deserializeLambda$ method) specified by the
+     * lambdaCapturingClass.
      *
      * @since 22.3
      */

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/ResourcesRegistry.java

@@ -61,7 +61,8 @@ default void addResourceBundles(String name) {
 
     /**
      * Although the interface-methods below are already defined in the super-interface
-     * {@link RuntimeResourceSupport} they are also needed here for backwards compatibility.
+     * {@link RuntimeResourceSupport} they are also needed here for legacy code that accesses them
+     * reflectively.
      */
     @Override
     void addResources(ConfigurationCondition condition, String pattern);

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jni/JNIAccessFeature.java

@@ -148,7 +148,7 @@ static final class JNICallableJavaMethod {
         }
     }
 
-    private JNIRuntimeAccessibilitySupportImpl runtimeAccessibilitySupport;
+    private JNIRuntimeAccessibilitySupportImpl runtimeSupport;
 
     private boolean sealed = false;
     private final Map<String, JNICallTrampolineMethod> trampolineMethods = new ConcurrentHashMap<>();
@@ -187,10 +187,10 @@ public void afterRegistration(AfterRegistrationAccess arg) {
 
         JNIReflectionDictionary.create();
 
-        runtimeAccessibilitySupport = new JNIRuntimeAccessibilitySupportImpl();
-        ImageSingletons.add(RuntimeJNIAccessSupport.class, runtimeAccessibilitySupport);
+        runtimeSupport = new JNIRuntimeAccessibilitySupportImpl();
+        ImageSingletons.add(RuntimeJNIAccessSupport.class, runtimeSupport);
 
-        ReflectionConfigurationParser<ConditionalElement<Class<?>>> parser = ConfigurationParserUtils.create(runtimeAccessibilitySupport, access.getImageClassLoader());
+        ReflectionConfigurationParser<ConditionalElement<Class<?>>> parser = ConfigurationParserUtils.create(runtimeSupport, access.getImageClassLoader());
         loadedConfigurations = ConfigurationParserUtils.parseAndRegisterConfigurations(parser, access.getImageClassLoader(), "JNI",
                         ConfigurationFiles.Options.JNIConfigurationFiles, ConfigurationFiles.Options.JNIConfigurationResources, ConfigurationFile.JNI.getFileName());
     }
@@ -247,7 +247,7 @@ public void beforeAnalysis(BeforeAnalysisAccess arg) {
     }
 
     private static ConditionalConfigurationRegistry getConditionalConfigurationRegistry() {
-        return singleton().runtimeAccessibilitySupport;
+        return singleton().runtimeSupport;
     }
 
     private static void registerJavaCallTrampoline(BeforeAnalysisAccessImpl access, CallVariant variant, boolean nonVirtual) {